(fix) Handle updates points after purshase places

Author: br-imen

.gitignore

@@ -4,4 +4,5 @@ lib
 .Python
 tests/
 .envrc
-__pycache__
+__pycache__
+.DS_Store

clubs.json

@@ -1,16 +1,19 @@
-{"clubs":[
-    {
-        "name":"Simply Lift",
-        "email":"john@simplylift.co",
-        "points":"13"
-    },
-    {
-        "name":"Iron Temple",
-        "email": "admin@irontemple.com",
-        "points":"4"
-    },
-    {   "name":"She Lifts",
-        "email": "kate@shelifts.co.uk",
-        "points":"12"
-    }
-]}
+{
+    "clubs": [
+        {
+            "name": "Simply Lift",
+            "email": "john@simplylift.co",
+            "points": "11"
+        },
+        {
+            "name": "Iron Temple",
+            "email": "admin@irontemple.com",
+            "points": "4"
+        },
+        {
+            "name": "She Lifts",
+            "email": "kate@shelifts.co.uk",
+            "points": "12"
+        }
+    ]
+}

server.py

@@ -3,9 +3,10 @@
 
 
 def loadClubs():
-    with open('clubs.json') as c:
-         listOfClubs = json.load(c)['clubs']
-         return listOfClubs
+    with open(app.config['CLUBS_FILE']) as c:
+        listOfClubs = json.load(c)['clubs']
+        return listOfClubs
+
 
 
 def loadCompetitions():
@@ -43,10 +44,20 @@ def book(competition,club):
 
 @app.route('/purchasePlaces',methods=['POST'])
 def purchasePlaces():
+    dict_clubs = {}
     competition = [c for c in competitions if c['name'] == request.form['competition']][0]
-    club = [c for c in clubs if c['name'] == request.form['club']][0]
+    club, index_club = [(c, clubs.index(c)) for c in clubs if c['name'] == request.form['club']][0]
     placesRequired = int(request.form['places'])
     competition['numberOfPlaces'] = int(competition['numberOfPlaces'])-placesRequired
+    club['points'] = int(club['points']) - placesRequired
+    clubs[index_club]['points'] = str(club['points'])
+    dict_clubs["clubs"] = clubs
+    try:
+        with open(app.config['CLUBS_FILE'], 'w') as file_club:
+            json.dump(dict_clubs, file_club, indent=4)
+    except FileNotFoundError:
+        flash('File clubs not found')
+        return redirect(url_for('book'), competition, club)
     flash('Great-booking complete!')
     return render_template('welcome.html', club=club, competitions=competitions)
 

tests/test_endpoints.py

@@ -0,0 +1,39 @@
+import json
+import pytest
+from server import app
+
+@pytest.fixture
+def client(tmpdir):
+    original_clubs_file = tmpdir.join("clubs.json")
+    original_clubs_file.write(json.dumps({
+    "clubs": [
+        {"name": "Simply Lift", "email": "john@simplylift.co", "points": "11"},
+        {"name": "Iron Temple", "email": "admin@irontemple.com", "points": "4"},
+        {"name": "She Lifts", "email": "kate@shelifts.co.uk", "points": "12"}
+    ]
+    }, indent=4))
+    app.config['CLUBS_FILE'] = str(original_clubs_file)
+    return app.test_client()
+
+def test_purchasePlaces_update_points(client):
+    response = client.post("/purchasePlaces", data = {"places":1,"competition":"Fall Classic","club":"Iron Temple"})
+    assert response.status_code == 200
+    assert b'Great-booking complete!' in response.data
+    # Verify the points and number of places have been updated
+    with open(app.config['CLUBS_FILE']) as f:
+        updated_clubs = json.load(f)['clubs']
+        updated_club = next(c for c in updated_clubs if c['name'] == 'Iron Temple')
+        assert updated_club['points'] == "3"
+
+def test_purchasePlaces_update_points_file_not_found(client):
+    app.config['CLUBS_FILE'] = ""
+    response = client.post("/purchasePlaces", data = {"places":1,"competition":"Fall Classic","club":"Iron Temple"})
+    assert response.status_code == 500
+    # assert b'File clubs not found' in response.data
+
+def test_purchasePlaces_update_points_club_not_found(client):
+    pass
+
+def test_purchasePlaces_update_points_more_than_available(client):
+    pass
+