(fix) Handle redeeming more points than available

br-imen · br-imen · commit 7069a6518d91 · 2024-05-31T00:55:02.000+02:00
diff --git a/server.py b/server.py
@@ -4,13 +4,13 @@
 
 def loadClubs():
     with open('clubs.json') as c:
-         listOfClubs = json.load(c)['clubs']
+         listOfClubs = json.load(c)["clubs"]
          return listOfClubs
 
 
 def loadCompetitions():
     with open('competitions.json') as comps:
-         listOfCompetitions = json.load(comps)['competitions']
+         listOfCompetitions = json.load(comps)["competitions"]
          return listOfCompetitions
 
 
@@ -45,8 +45,15 @@ def book(competition,club):
 def purchasePlaces():
     competition = [c for c in competitions if c['name'] == request.form['competition']][0]
     club = [c for c in clubs if c['name'] == request.form['club']][0]
+    if not request.form['places'] or int(request.form['places']) < 1 :
+        flash("Places required must be a positive integer")
+        return redirect(url_for('book',competition=competition['name'],club=club['name']))
     placesRequired = int(request.form['places'])
-    competition['numberOfPlaces'] = int(competition['numberOfPlaces'])-placesRequired
+    if placesRequired > int(club['points']):
+        flash("Places required exceed club's total points")
+        return redirect(url_for('book',competition=competition['name'],club=club['name']))
+    competition['numberOfPlaces'] = int(competition['numberOfPlaces']) - placesRequired
+    club['points'] = int(club['points']) - placesRequired
     flash('Great-booking complete!')
     return render_template('welcome.html', club=club, competitions=competitions)
 
diff --git a/templates/booking.html b/templates/booking.html
@@ -6,6 +6,15 @@
 </head>
 <body>
     <h2>{{competition['name']}}</h2>
+    {% with messages = get_flashed_messages()%}
+    {% if messages %}
+        <ul>
+       {% for message in messages %}
+            <li>{{message}}</li>
+        {% endfor %}
+       </ul>
+    {% endif%}
+    {% endwith %}
     Places available: {{competition['numberOfPlaces']}}
     <form action="/purchasePlaces" method="post">
         <input type="hidden" name="club" value="{{club['name']}}">
