From 67997a10647fbfcadc322e4cd8073ee6162c4f66 Mon Sep 17 00:00:00 2001 From: Quentin Desrame Date: Wed, 20 Feb 2019 13:38:01 +0100 Subject: [PATCH 1/2] fix(utils): replace return in RefPointer --- .../java/com/qdesrame/openapi/diff/utils/RefPointer.java | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/main/java/com/qdesrame/openapi/diff/utils/RefPointer.java b/src/main/java/com/qdesrame/openapi/diff/utils/RefPointer.java index 4cc8e715f..a1382bfa8 100644 --- a/src/main/java/com/qdesrame/openapi/diff/utils/RefPointer.java +++ b/src/main/java/com/qdesrame/openapi/diff/utils/RefPointer.java @@ -28,22 +28,16 @@ private Map getMap(Components components) { switch (refType) { case REQUEST_BODIES: return (Map) components.getRequestBodies(); - case RESPONSES: return (Map) components.getResponses(); - case PARAMETERS: return (Map) components.getParameters(); - case SCHEMAS: return (Map) components.getSchemas(); - case HEADERS: - return (Map) components.getSchemas(); - + return (Map) components.getHeaders(); case SECURITY_SCHEMES: return (Map) components.getSecuritySchemes(); - default: throw new IllegalArgumentException("Not mapped for refType: " + refType); } From 527366919e3f76fddd6fb5a6a849b1951c698f44 Mon Sep 17 00:00:00 2001 From: Quentin Desrame Date: Wed, 20 Feb 2019 13:39:23 +0100 Subject: [PATCH 2/2] format(output): reformat markdown renderer according google format --- .../java/com/qdesrame/openapi/diff/compare/SchemaDiff.java | 2 +- .../java/com/qdesrame/openapi/diff/output/MarkdownRender.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/qdesrame/openapi/diff/compare/SchemaDiff.java b/src/main/java/com/qdesrame/openapi/diff/compare/SchemaDiff.java index e50754dd7..9d8b774da 100644 --- a/src/main/java/com/qdesrame/openapi/diff/compare/SchemaDiff.java +++ b/src/main/java/com/qdesrame/openapi/diff/compare/SchemaDiff.java @@ -84,7 +84,7 @@ protected static Schema resolveComposedSchema(Components components, Schema sche return schema; } - protected static Schema addSchema(Schema schema, Schema fromSchema) { + protected static Schema addSchema(Schema schema, Schema fromSchema) { if (fromSchema.getProperties() != null) { if (schema.getProperties() == null) { schema.setProperties(fromSchema.getProperties()); diff --git a/src/main/java/com/qdesrame/openapi/diff/output/MarkdownRender.java b/src/main/java/com/qdesrame/openapi/diff/output/MarkdownRender.java index 73a519f8c..9e1729e70 100644 --- a/src/main/java/com/qdesrame/openapi/diff/output/MarkdownRender.java +++ b/src/main/java/com/qdesrame/openapi/diff/output/MarkdownRender.java @@ -175,8 +175,8 @@ protected String itemResponse(String title, String code, String description) { protected String headers(ChangedHeaders headers) { StringBuilder sb = new StringBuilder(); if (headers != null) { - sb.append(listHeader("New header", headers.getIncreased())); - sb.append(listHeader("Deleted header", headers.getMissing())); + sb.append(listHeader("New header", headers.getIncreased())) + .append(listHeader("Deleted header", headers.getMissing())); headers .getChanged() .entrySet()