From 4c530db082cf40faf33c72fea2e352e7b9c04fad Mon Sep 17 00:00:00 2001 From: Sven Linstaedt Date: Thu, 27 Jan 2022 16:25:01 +0100 Subject: [PATCH] fix: adding response media type is breaking --- .../openapitools/openapidiff/core/model/ChangedContent.java | 2 +- .../org/openapitools/openapidiff/core/ContentDiffTest.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/main/java/org/openapitools/openapidiff/core/model/ChangedContent.java b/core/src/main/java/org/openapitools/openapidiff/core/model/ChangedContent.java index 5bc6ddf2a..192b49e66 100644 --- a/core/src/main/java/org/openapitools/openapidiff/core/model/ChangedContent.java +++ b/core/src/main/java/org/openapitools/openapidiff/core/model/ChangedContent.java @@ -31,7 +31,7 @@ public DiffResult isCoreChanged() { if (increased.isEmpty() && missing.isEmpty()) { return DiffResult.NO_CHANGES; } - if (context.isRequest() && missing.isEmpty() || context.isResponse() && increased.isEmpty()) { + if (context.isRequest() && missing.isEmpty() || context.isResponse() && missing.isEmpty()) { return DiffResult.COMPATIBLE; } return DiffResult.INCOMPATIBLE; diff --git a/core/src/test/java/org/openapitools/openapidiff/core/ContentDiffTest.java b/core/src/test/java/org/openapitools/openapidiff/core/ContentDiffTest.java index 190b5a32f..e3cf03534 100644 --- a/core/src/test/java/org/openapitools/openapidiff/core/ContentDiffTest.java +++ b/core/src/test/java/org/openapitools/openapidiff/core/ContentDiffTest.java @@ -33,7 +33,7 @@ public void testAddedResponseContentTypeDiff() { ChangedOpenApi changedOpenApi = OpenApiCompare.fromLocations( "content_type_response_add_1.yaml", "content_type_response_add_2.yaml"); - assertThat(changedOpenApi.isCompatible()).isFalse(); + assertThat(changedOpenApi.isCompatible()).isTrue(); } @Test @@ -41,7 +41,7 @@ public void testRemovedResponseContentTypeDiff() { ChangedOpenApi changedOpenApi = OpenApiCompare.fromLocations( "content_type_response_add_2.yaml", "content_type_response_add_1.yaml"); - assertThat(changedOpenApi.isCompatible()).isTrue(); + assertThat(changedOpenApi.isCompatible()).isFalse(); } @Test