Skip to content

Commit 70a6fb6

Browse files
committed
Code refactoring
1 parent 56242b3 commit 70a6fb6

File tree

1 file changed

+11
-29
lines changed

1 file changed

+11
-29
lines changed

src/main/java/com/qdesrame/openapi/diff/output/MarkdownRender.java

Lines changed: 11 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,10 @@ public MarkdownRender() {
4343

4444
public String render(ChangedOpenApi diff) {
4545
this.diff = diff;
46-
StringBuilder sb = new StringBuilder();
47-
sb.append(listEndpoints("What's New", diff.getNewEndpoints()))
48-
.append(listEndpoints("What's Deleted", diff.getMissingEndpoints()))
49-
.append(listEndpoints("What's Deprecated", diff.getDeprecatedEndpoints()))
50-
.append(listEndpoints(diff.getChangedOperations()));
51-
return sb.toString();
46+
return listEndpoints("What's New", diff.getNewEndpoints()) +
47+
listEndpoints("What's Deleted", diff.getMissingEndpoints()) +
48+
listEndpoints("What's Deprecated", diff.getDeprecatedEndpoints()) +
49+
listEndpoints(diff.getChangedOperations());
5250
}
5351

5452
protected String sectionTitle(String title) {
@@ -63,11 +61,7 @@ protected String listEndpoints(String title, List<Endpoint> endpoints) {
6361
}
6462

6563
protected String itemEndpoint(String method, String path, String summary) {
66-
StringBuilder sb = new StringBuilder();
67-
sb.append(H5).append(CODE).append(method).append(CODE).append(" ")
68-
.append(path).append("\n\n").append(description(summary)).append("\n");
69-
/*.append(desc.replaceAll("\n", "\n> "))*/
70-
return sb.toString();
64+
return H5 + CODE + method + CODE + " " + path + "\n\n" + description(summary) + "\n";
7165
}
7266

7367
protected String titleH5(String title) {
@@ -155,17 +149,12 @@ protected String itemHeader(String title, String name, Header header) {
155149
}
156150

157151
protected String itemHeader(String code, ChangedHeader header) {
158-
StringBuilder sb = new StringBuilder();
159-
sb.append(this.itemHeader("Changed header", code, null == header.getNewHeader() ?
160-
"" : header.getNewHeader().getDescription()));
161-
return sb.toString();
152+
return this.itemHeader("Changed header", code, null == header.getNewHeader() ?
153+
"" : header.getNewHeader().getDescription());
162154
}
163155

164156
protected String itemHeader(String title, String mediaType, String description) {
165-
StringBuilder sb = new StringBuilder("");
166-
sb.append(format("%s : `%s`\n\n", title, mediaType));
167-
sb.append(description(description)).append('\n');
168-
return sb.toString();
157+
return format("%s : `%s`\n\n", title, mediaType) + description(description) + '\n';
169158
}
170159

171160
protected String bodyContent(String prefix, ChangedContent changedContent) {
@@ -193,22 +182,15 @@ protected String listContent(String prefix, String title, Map<String, MediaType>
193182
}
194183

195184
protected String itemContent(String title, String mediaType) {
196-
StringBuilder sb = new StringBuilder("");
197-
sb.append(format("%s : `%s`\n\n", title, mediaType));
198-
return sb.toString();
185+
return format("%s : `%s`\n\n", title, mediaType);
199186
}
200187

201188
protected String itemContent(String title, String mediaType, MediaType content) {
202-
StringBuilder sb = new StringBuilder("");
203-
sb.append(itemContent(title, mediaType));
204-
return sb.toString();
189+
return itemContent(title, mediaType);
205190
}
206191

207192
protected String itemContent(int deepness, String mediaType, ChangedMediaType content) {
208-
StringBuilder sb = new StringBuilder("");
209-
sb.append(itemContent("Changed content type", mediaType));
210-
sb.append(schema(deepness, content.getChangedSchema()));
211-
return sb.toString();
193+
return itemContent("Changed content type", mediaType) + schema(deepness, content.getChangedSchema());
212194
}
213195

214196
protected String schema(ChangedSchema schema) {

0 commit comments

Comments
 (0)