Parameter and response bug fix

Adarsh Sharma · Adarsh Sharma · commit 697acf795672 · 2017-12-29T01:54:42.000+05:30
diff --git a/src/main/java/com/qdesrame/openapi/diff/compare/ParametersDiff.java b/src/main/java/com/qdesrame/openapi/diff/compare/ParametersDiff.java
@@ -37,7 +37,7 @@ public static boolean same(Parameter left, Parameter right) {
     }
 
     public ChangedParameters diff(List<Parameter> left, List<Parameter> right) {
-        ChangedParameters result = new ChangedParameters(left, right);
+        ChangedParameters result = new ChangedParameters(left, new ArrayList<>(right));
         if (null == left) left = new ArrayList<>();
         if (null == right) right = new ArrayList<>();
 
diff --git a/src/main/java/com/qdesrame/openapi/diff/model/ChangedResponse.java b/src/main/java/com/qdesrame/openapi/diff/model/ChangedResponse.java
@@ -49,7 +49,8 @@ public void setChangedHeaders(ChangedHeaders changedHeaders) {
 
     @Override
     public boolean isDiff() {
-        return (changedContent != null && changedContent.isDiff())
+        return changeDescription
+                ||(changedContent != null && changedContent.isDiff())
                 || (changedHeaders != null && changedHeaders.isDiff());
     }
 

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public static boolean same(Parameter left, Parameter right) {`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`public ChangedParameters diff(List<Parameter> left, List<Parameter> right) {`
`40`		`- ChangedParameters result = new ChangedParameters(left, right);`
	`40`	`+ ChangedParameters result = new ChangedParameters(left, new ArrayList<>(right));`
`41`	`41`	`if (null == left) left = new ArrayList<>();`
`42`	`42`	`if (null == right) right = new ArrayList<>();`
`43`	`43`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,8 @@ public void setChangedHeaders(ChangedHeaders changedHeaders) {`
`49`	`49`
`50`	`50`	`@Override`
`51`	`51`	`public boolean isDiff() {`
`52`		`- return (changedContent != null && changedContent.isDiff())`
	`52`	`+ return changeDescription`
	`53`	`+ \|\|(changedContent != null && changedContent.isDiff())`
`53`	`54`	`\|\| (changedHeaders != null && changedHeaders.isDiff());`
`54`	`55`	`}`
`55`	`56`