Skip to content
This repository was archived by the owner on May 24, 2023. It is now read-only.

Commit cd2520a

Browse files
author
Mark Lewin
authored
Remove deprecated fields from Update Number snippet (Vonage#70)
* Remove deprecated env variable * Use app_id instead of deprecated messagesCallback*
1 parent a0bccce commit cd2520a

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

example.env

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ TO_NUMBER='EXAMPLE_TO_NUMBER'
44
RECIPIENT_NUMBER='EXAMPLE_RECIPIENT_NUMBER'
55
FROM_NUMBER='EXAMPLE_FROM_NUMBER'
66
NEXMO_BRAND_NAME='Acme Inc.'
7+
NEXMO_APPLICATION_ID='12a3b4cd-a1b2-1ab2-a1b2-a1234bc5d678'
78

89
# Number Insight examples
910
INSIGHT_NUMBER='NUMBER_FOR_INSIGHT'
@@ -18,7 +19,6 @@ NUMBER_SEARCH_PATTERN=1
1819
NEXMO_NUMBER='447700900001'
1920
NEXMO_NUMBER_TYPE='mobile-lvn'
2021
NEXMO_NUMBER_FEATURES='SMS,VOICE'
21-
MESSAGES_APPLICATION_ID='12a3b4cd-a1b2-1ab2-a1b2-a1234bc5d678'
2222
VOICE_CALLBACK_TYPE='tel'
2323
VOICE_CALLBACK_VALUE='447700900002'
2424
VOICE_STATUS_URL='https://example.com/webhooks/status'

numbers/update.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
NEXMO_API_SECRET = os.getenv("NEXMO_API_SECRET")
1010
NEXMO_NUMBER = os.getenv("NEXMO_NUMBER")
1111
COUNTRY_CODE = os.getenv("COUNTRY_CODE")
12-
MESSAGES_APPLICATION_ID = os.getenv("MESSAGES_APPLICATION_ID")
12+
NEXMO_APPLICATION_ID = os.getenv("NEXMO_APPLICATION_ID")
1313
VOICE_CALLBACK_TYPE = os.getenv("VOICE_CALLBACK_TYPE")
1414
VOICE_CALLBACK_VALUE = os.getenv("VOICE_CALLBACK_VALUE")
1515
VOICE_STATUS_URL = os.getenv("VOICE_STATUS_URL")
@@ -24,8 +24,7 @@
2424
{
2525
"msisdn": NEXMO_NUMBER,
2626
"country": COUNTRY_CODE,
27-
"messagesCallbackType": "app",
28-
"messagesCallbackValue": MESSAGES_APPLICATION_ID,
27+
"app_id": NEXMO_APPLICATION_ID,
2928
"voiceCallbackType": VOICE_CALLBACK_TYPE,
3029
"voiceCallbackValue": VOICE_CALLBACK_VALUE,
3130
"voiceStatusCallback": VOICE_STATUS_URL,

0 commit comments

Comments
 (0)