Skip to content

Commit 170ae0f

Browse files
committed
Revert "ggml : add ggml_gelu_erf() CUDA kernel (ggml-org#13719)"
This reverts commit 4c32832.
1 parent 7758c83 commit 170ae0f

File tree

3 files changed

+0
-16
lines changed

3 files changed

+0
-16
lines changed

ggml/src/ggml-cuda/ggml-cuda.cu

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2182,9 +2182,6 @@ static bool ggml_cuda_compute_forward(ggml_backend_cuda_context & ctx, struct gg
21822182
case GGML_UNARY_OP_SILU:
21832183
ggml_cuda_op_silu(ctx, dst);
21842184
break;
2185-
case GGML_UNARY_OP_GELU_ERF:
2186-
ggml_cuda_op_gelu_erf(ctx, dst);
2187-
break;
21882185
case GGML_UNARY_OP_GELU_QUICK:
21892186
ggml_cuda_op_gelu_quick(ctx, dst);
21902187
break;
@@ -2970,7 +2967,6 @@ static bool ggml_backend_cuda_device_supports_op(ggml_backend_dev_t dev, const g
29702967
case GGML_UNARY_OP_SIGMOID:
29712968
case GGML_UNARY_OP_HARDSIGMOID:
29722969
case GGML_UNARY_OP_HARDSWISH:
2973-
case GGML_UNARY_OP_GELU_ERF:
29742970
case GGML_UNARY_OP_GELU_QUICK:
29752971
case GGML_UNARY_OP_TANH:
29762972
case GGML_UNARY_OP_EXP:

ggml/src/ggml-cuda/unary.cu

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,6 @@ static __device__ __forceinline__ float op_gelu(float x) {
2323
return 0.5f*x*(1.0f + tanhf(SQRT_2_OVER_PI*x*(1.0f + GELU_COEF_A*x*x)));
2424
}
2525

26-
static __device__ __forceinline__ float op_gelu_erf(float x) {
27-
const float SQRT_2_INV = 0.70710678118654752440084436210484f;
28-
29-
return 0.5f*x*(1.0f + erff(x*SQRT_2_INV));
30-
}
31-
3226
static __device__ __forceinline__ float op_gelu_quick(float x) {
3327
const float GELU_QUICK_COEF = -1.702f;
3428

@@ -140,10 +134,6 @@ void ggml_cuda_op_gelu(ggml_backend_cuda_context & ctx, ggml_tensor * dst) {
140134
ggml_cuda_op_unary<op_gelu>(ctx, dst);
141135
}
142136

143-
void ggml_cuda_op_gelu_erf(ggml_backend_cuda_context & ctx, ggml_tensor * dst) {
144-
ggml_cuda_op_unary<op_gelu_erf>(ctx, dst);
145-
}
146-
147137
void ggml_cuda_op_gelu_quick(ggml_backend_cuda_context & ctx, ggml_tensor * dst) {
148138
ggml_cuda_op_unary<op_gelu_quick>(ctx, dst);
149139
}

ggml/src/ggml-cuda/unary.cuh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ void ggml_cuda_op_silu(ggml_backend_cuda_context & ctx, ggml_tensor * dst);
3030

3131
void ggml_cuda_op_silu_back(ggml_backend_cuda_context & ctx, ggml_tensor * dst);
3232

33-
void ggml_cuda_op_gelu_erf(ggml_backend_cuda_context & ctx, ggml_tensor * dst);
34-
3533
void ggml_cuda_op_gelu_quick(ggml_backend_cuda_context & ctx, ggml_tensor * dst);
3634

3735
void ggml_cuda_op_tanh(ggml_backend_cuda_context & ctx, ggml_tensor * dst);

0 commit comments

Comments
 (0)