From d754e9ae143a3163a7c9ff3a6b797efdca678683 Mon Sep 17 00:00:00 2001 From: Shawn Silverman Date: Wed, 15 Nov 2023 17:47:02 -0800 Subject: [PATCH 1/2] Fix client.connect() check Implicit boolean conversion will convert errors into 'true'. --- examples/LegacyEthernetTest/LegacyEthernetTest.ino | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/LegacyEthernetTest/LegacyEthernetTest.ino b/examples/LegacyEthernetTest/LegacyEthernetTest.ino index 5033c9d..a32861a 100644 --- a/examples/LegacyEthernetTest/LegacyEthernetTest.ino +++ b/examples/LegacyEthernetTest/LegacyEthernetTest.ino @@ -168,7 +168,7 @@ void testEthernet(bool dhcp) { Serial.print("Attempt to connect to port 80 on "); Serial.println(Ethernet.gatewayIP()); EthernetClient client; - if (client.connect(Ethernet.gatewayIP(), 80)) { + if (client.connect(Ethernet.gatewayIP(), 80) == 1) { Serial.println("\t...success"); } else { Serial.println("\t...ERROR"); From f357af2948c865bdaf0672b0012d9bc90e1e715d Mon Sep 17 00:00:00 2001 From: Shawn Silverman Date: Wed, 15 Nov 2023 17:51:24 -0800 Subject: [PATCH 2/2] Update gateway connect to try both port 80 and port 443 Some gateways might disable port 80. --- examples/LegacyEthernetTest/LegacyEthernetTest.ino | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/examples/LegacyEthernetTest/LegacyEthernetTest.ino b/examples/LegacyEthernetTest/LegacyEthernetTest.ino index a32861a..dc5e604 100644 --- a/examples/LegacyEthernetTest/LegacyEthernetTest.ino +++ b/examples/LegacyEthernetTest/LegacyEthernetTest.ino @@ -165,15 +165,18 @@ void testEthernet(bool dhcp) { printEthernetStatus(); Serial.println(); - Serial.print("Attempt to connect to port 80 on "); + Serial.print("Attempt to connect to port 80 or 443 on "); Serial.println(Ethernet.gatewayIP()); EthernetClient client; if (client.connect(Ethernet.gatewayIP(), 80) == 1) { - Serial.println("\t...success"); + Serial.println("\t...success (port 80)"); + client.stop(); + } else if (client.connect(Ethernet.gatewayIP(), 443) == 1) { + Serial.println("\t...success (port 443)"); + client.stop(); } else { Serial.println("\t...ERROR"); } - client.stop(); Serial.println(); }