Skip to content

Commit ab75716

Browse files
committed
Merge branch 'master' into improve-nc-mysql-host-port
# Conflicts: # root/etc/cont-init.d/50-config
2 parents 60ac384 + d16c8aa commit ab75716

File tree

5 files changed

+10
-9
lines changed

5 files changed

+10
-9
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ Container images are configured using parameters passed at runtime (such as thos
159159
| `-e DB_HOST=<yourdbhost>` | for specifying the database host |
160160
| `-e DB_USER=<yourdbuser>` | for specifying the database user |
161161
| `-e DB_PASS=<yourdbpass>` | for specifying the database password |
162-
| `-e DB_DATABASE=bookstackapp` | for specifying the database to be used |
162+
| `-e DB_DATABASE=bookstackapp` | for specifying the database to be used (non-alphanumeric passwords must be properly escaped.) |
163163
| `-v /config` | this will store any uploaded data on the docker host |
164164

165165
## Environment variables from files (Docker secrets)
@@ -271,6 +271,7 @@ Once registered you can define the dockerfile to use with `-f Dockerfile.aarch64
271271

272272
## Versions
273273

274+
* **10.10.22:** - Remove password escape logic which caused problems for a small subset of users.
274275
* **20.08.22:** - Rebasing to alpine 3.15 with php8. Restructure nginx configs ([see changes announcement](https://info.linuxserver.io/issues/2022-08-20-nginx-base)).
275276
* **14.03.22:** - Add symlinks for theme support.
276277
* **11.07.21:** - Rebase to Alpine 3.14.

package_versions.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ ca-certificates-20220614-r0
1212
ca-certificates-bundle-20220614-r0
1313
coreutils-9.0-r2
1414
curl-7.80.0-r3
15-
dbus-libs-1.12.20-r4
15+
dbus-libs-1.12.24-r0
1616
encodings-1.0.5-r0
17-
expat-2.4.7-r0
17+
expat-2.4.9-r0
1818
fontconfig-2.13.1-r4
1919
freetype-2.11.1-r2
2020
gdbm-1.22-r0

readme-vars.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ param_env_vars:
3030
- { env_var: "DB_PORT", env_value: "<yourdbport>", desc: "for specifying the database port if not default 3306" }
3131
- { env_var: "DB_USER", env_value: "<yourdbuser>", desc: "for specifying the database user" }
3232
- { env_var: "DB_PASS", env_value: "<yourdbpass>", desc: "for specifying the database password" }
33-
- { env_var: "DB_DATABASE", env_value: "bookstackapp", desc: "for specifying the database to be used" }
33+
- { env_var: "DB_DATABASE", env_value: "bookstackapp", desc: "for specifying the database to be used (non-alphanumeric passwords must be properly escaped.)" }
3434

3535
param_usage_include_ports: true
3636
param_ports:
@@ -103,6 +103,7 @@ app_setup_block: |
103103
104104
# changelog
105105
changelogs:
106+
- { date: "10.10.22:", desc: "Remove password escape logic which caused problems for a small subset of users." }
106107
- { date: "20.08.22:", desc: "Rebasing to alpine 3.15 with php8. Restructure nginx configs ([see changes announcement](https://info.linuxserver.io/issues/2022-08-20-nginx-base))." }
107108
- { date: "14.03.22:", desc: "Add symlinks for theme support." }
108109
- { date: "11.07.21:", desc: "Rebase to Alpine 3.14." }

root/defaults/nginx/site-confs/default.conf.sample

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
## Version 2022/08/20 - Changelog: https://github.com/linuxserver/docker-bookstack/commits/master/root/defaults/nginx/site-confs/default.conf.sample
1+
## Version 2022/10/04 - Changelog: https://github.com/linuxserver/docker-bookstack/commits/master/root/defaults/nginx/site-confs/default.conf.sample
22

33
server {
44
listen 80 default_server;
55
listen [::]:80 default_server;
66

7-
listen 443 ssl http2;
8-
listen [::]:443 ssl http2;
7+
listen 443 ssl http2 default_server;
8+
listen [::]:443 ssl http2 default_server;
99

1010
server_name _;
1111

root/etc/cont-init.d/50-config

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,10 @@ fi
6363
if [ "${DB_USER}" ];
6464
then
6565
echo "Running config - db_user set"
66-
ESCAPED_PASSWORD=$(sed -E 's/('\'')/\\\1/g' <<< $DB_PASS)
6766
sed -i "s/^DB_HOST=.*/DB_HOST=${DB_HOST}/g" /config/www/.env
6867
sed -i "s/^DB_DATABASE=.*/DB_DATABASE=${DB_DATABASE}/g" /config/www/.env
6968
sed -i "s/^DB_USERNAME=.*/DB_USERNAME=${DB_USER}/g" /config/www/.env
70-
sed -i "s/^DB_PASSWORD=.*/DB_PASSWORD=${ESCAPED_PASSWORD}/g" /config/www/.env
69+
sed -i "s/^DB_PASSWORD=.*/DB_PASSWORD=${DB_PASS}/g" /config/www/.env
7170

7271
if [ -n "${DB_PORT}" ]; then
7372
if ! grep -xq "^DB_PORT=.*" /config/www/.env; then

0 commit comments

Comments
 (0)