From e493aa65f0fe05ce1796041c847c2ec558024c55 Mon Sep 17 00:00:00 2001 From: sis0k0 Date: Sun, 4 Mar 2018 10:52:12 +0200 Subject: [PATCH 1/5] docs: fix link in contributing guide --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b35f34f4..518acd6b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ - [Introduction](#introduction) - [Project Structure](#project-structure) - [Setup](#setup) -- [Testing locally](#testing-locally) +- [Testing locally](#testing-locally-by-running-e2e-tests) - [Reporting Bugs](#reporting-bugs) - [Requesting Features](#requesting-features) - [Submitting PR](#submitting-pr) From fcff61bff51f4bedb548facf9c2dd68986f9321e Mon Sep 17 00:00:00 2001 From: sis0k0 Date: Sun, 4 Mar 2018 10:53:18 +0200 Subject: [PATCH 2/5] docs: add a PR template --- .github/PULL_REQUEST_TEMPLATE.md | 36 ++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..ee3a44c4 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,36 @@ + + + + + +## PR Checklist + +- [ ] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. +- [ ] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. +- [ ] You have signed the [CLA](http://www.nativescript.org/cla). +- [ ] All existing tests are passing: https://github.com/NativeScript/nativescript-dev-webpack/blob/master/CONTRIBUTING.md#testing-locally-by-running-e2e-tests + +## What is the current behavior? + + +## What is the new behavior? + + +Fixes/Implements/Closes #[Issue Number]. + + + + + From d9d1ef249060cdcf8da0761198b352aec4815e20 Mon Sep 17 00:00:00 2001 From: sis0k0 Date: Sun, 4 Mar 2018 17:16:58 +0200 Subject: [PATCH 3/5] docs: add an issue template --- .github/ISSUE_TEMPLATE.md | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE.md diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md new file mode 100644 index 00000000..c7b44325 --- /dev/null +++ b/.github/ISSUE_TEMPLATE.md @@ -0,0 +1,36 @@ + + + + + +## Issue Checklist + +- [ ] You are submitting: +- [ ] You verified that this is a real problem by searching the [NativeScript Forum](http://forum.nativescript.org) and the +[other issues in this repo](https://github.com/nativescript/nativescript-dev-webpack/issues?utf8=✓&q=is%3Aissue). + +## Tell us about the problem + + +## Local environment + +- [ ] Platform +- [ ] Node version XX +- [ ] NativeScript CLI version + +## Project data + +- [ ] Platform you are building the app for +- [ ] Node dependencies: +``` + +``` +- [ ] Webpack configuration: +``` + +``` + From 8186ffee7fa7b2b2f1825393418caf2f17681d94 Mon Sep 17 00:00:00 2001 From: sis0k0 Date: Thu, 8 Mar 2018 15:13:26 +0200 Subject: [PATCH 4/5] docs: extract links in ISSUE_TEMPLATE --- .github/ISSUE_TEMPLATE.md | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index c7b44325..34895527 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -9,9 +9,9 @@ To help the rest of the community review your issue, please follow the instructi ## Issue Checklist -- [ ] You are submitting: -- [ ] You verified that this is a real problem by searching the [NativeScript Forum](http://forum.nativescript.org) and the -[other issues in this repo](https://github.com/nativescript/nativescript-dev-webpack/issues?utf8=✓&q=is%3Aissue). +- [ ] You are submitting: +- [ ] You verified that this is a real problem by searching the [NativeScript Forum] and the other [issues] in this repo. +- [ ] You checked our [demo apps] and the [documentation] for sample usage. ## Tell us about the problem @@ -34,3 +34,7 @@ To help the rest of the community review your issue, please follow the instructi ``` +[NativeScript Forum]: http://forum.nativescript.org +[issues]: https://github.com/nativescript/nativescript-dev-webpack/issues?utf8=✓&q=is%3Aissue +[demo apps]: ../demo +[documentation]: https://docs.nativescript.org/best-practices/bundling-with-webpack From 4d73ae0708ed29362fc0628a460506663e31d250 Mon Sep 17 00:00:00 2001 From: sis0k0 Date: Thu, 8 Mar 2018 15:13:48 +0200 Subject: [PATCH 5/5] docs: add note for adding new tests in PR template --- .github/PULL_REQUEST_TEMPLATE.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ee3a44c4..d5b81f7c 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -11,8 +11,9 @@ To help the rest of the community review your change, please follow the instruct - [ ] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. - [ ] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. -- [ ] You have signed the [CLA](http://www.nativescript.org/cla). +- [ ] You have signed the [CLA]. - [ ] All existing tests are passing: https://github.com/NativeScript/nativescript-dev-webpack/blob/master/CONTRIBUTING.md#testing-locally-by-running-e2e-tests +- [ ] Tests for the changes are included. ## What is the current behavior? @@ -34,3 +35,5 @@ Migration steps: [Provide a migration path for existing applications.] --> + +[CLA]: http://www.nativescript.org/cla \ No newline at end of file