From 23aa6c564b32f20a3b3f040dee509d68b8f3b916 Mon Sep 17 00:00:00 2001 From: DimitarTachev Date: Wed, 12 Feb 2020 13:51:10 +0200 Subject: [PATCH 1/2] fix: `The provided Android NDK is vnull while the recommended one is v21.0.6113669` error in some cases --- snapshot/android/snapshot-generator.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/snapshot/android/snapshot-generator.js b/snapshot/android/snapshot-generator.js index d3b54d22..eb055dcd 100644 --- a/snapshot/android/snapshot-generator.js +++ b/snapshot/android/snapshot-generator.js @@ -400,7 +400,11 @@ SnapshotGenerator.prototype.buildCSource = function (androidArch, blobInputDir, } SnapshotGenerator.prototype.getRecommendedNdkWarning = function (localNdkRevision, recommendedAndroidNdkRevision) { - return `The provided Android NDK is v${localNdkRevision} while the recommended one is v${recommendedAndroidNdkRevision}`; + if (localNdkRevision) { + return `The provided Android NDK is v${localNdkRevision} while the required one is v${recommendedAndroidNdkRevision}`; + } else { + return `The provided Android NDK version is different than the required one - v${recommendedAndroidNdkRevision}`; + } } SnapshotGenerator.prototype.runMksnapshotTool = function (tool, mksnapshotParams, inputFile, snapshotInDocker, snapshotToolsPath, buildCSource) { From 45ef0042b6e2ed9f818f0723428c56b60e9bfa8f Mon Sep 17 00:00:00 2001 From: DimitarTachev Date: Wed, 12 Feb 2020 13:55:56 +0200 Subject: [PATCH 2/2] chore: bump version --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index dc2d3e6f..1956f9aa 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "nativescript-dev-webpack", - "version": "1.5.0", + "version": "1.5.1", "main": "index", "description": "", "homepage": "http://www.telerik.com", @@ -100,4 +100,4 @@ "tns-core-modules": "next", "typescript": "~3.5.3" } -} +} \ No newline at end of file