From d0e54f17fb0f7914be95be996b630f253b02ba82 Mon Sep 17 00:00:00 2001 From: rosen-vladimirov Date: Wed, 21 Aug 2019 16:19:24 +0300 Subject: [PATCH] fix: stop generating snapshot for ia64 for older runtimes When the runtime version is below 6.0.2 we should generate snapshot only for armv7, arm64 and ia32 archs. However, as in the validation schema we have default value for the targetArchs, the logic that should determine if ia64 should be removed from the targetArchs decides the archs are passed by the user and does not strip anything from them. Remove the default values from the JSON Schema - they are calculated in the code, so there's no need to have them on two places. As we can not have our conditional logic in the JSON schema, keep calculation of the default values only in the code. --- plugins/NativeScriptSnapshotPlugin/options.json | 6 ------ 1 file changed, 6 deletions(-) diff --git a/plugins/NativeScriptSnapshotPlugin/options.json b/plugins/NativeScriptSnapshotPlugin/options.json index f18a2cd9..d20b74ac 100644 --- a/plugins/NativeScriptSnapshotPlugin/options.json +++ b/plugins/NativeScriptSnapshotPlugin/options.json @@ -25,12 +25,6 @@ }, "targetArchs": { "type": "array", - "default": [ - "arm", - "arm64", - "ia32", - "ia64" - ], "items": { "type": "string", "enum": [