Skip to content

Commit e24d98f

Browse files
committed
refactor: use not so generic names
1 parent a835f4b commit e24d98f

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

src/ui/picker-field-base.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export abstract class PickerFieldBase extends TextField {
88
public pickerOkText: string;
99
public pickerCancelText: string;
1010

11-
private _tapHandler: (args: TouchGestureEventData) => void;
11+
private _pickerFieldBaseTapHandler: (args: TouchGestureEventData) => void;
1212

1313
constructor() {
1414
super();
@@ -36,11 +36,11 @@ export abstract class PickerFieldBase extends TextField {
3636

3737
initNativeView() {
3838
super.initNativeView();
39-
this._updateHandler(true);
39+
this._updatePickerFieldBaseTapHandler(true);
4040
}
4141

4242
disposeNativeView() {
43-
this._updateHandler(false);
43+
this._updatePickerFieldBaseTapHandler(false);
4444
super.disposeNativeView();
4545
}
4646

@@ -51,18 +51,18 @@ export abstract class PickerFieldBase extends TextField {
5151
protected onLocaleChanged(oldValue: string, newValue: string) {
5252
}
5353

54-
private _updateHandler(subscribe: boolean) {
54+
private _updatePickerFieldBaseTapHandler(subscribe: boolean) {
5555
if (subscribe) {
56-
this._tapHandler = this._tapHandler || ((args: TouchGestureEventData) => {
57-
this._onTap(args);
56+
this._pickerFieldBaseTapHandler = this._pickerFieldBaseTapHandler || ((args: TouchGestureEventData) => {
57+
this._onPickerFieldBaseTap(args);
5858
});
59-
this.on(GestureTypes.tap, this._tapHandler);
59+
this.on(GestureTypes.tap, this._pickerFieldBaseTapHandler);
6060
} else {
61-
this.off(GestureTypes.tap, this._tapHandler);
61+
this.off(GestureTypes.tap, this._pickerFieldBaseTapHandler);
6262
}
6363
}
6464

65-
private _onTap(args: TouchGestureEventData) {
65+
private _onPickerFieldBaseTap(args: TouchGestureEventData) {
6666
this.open();
6767
}
6868
}

0 commit comments

Comments
 (0)