From 2d6d2edfa44aedaf4a1cef3ab072db6cc70bbb9d Mon Sep 17 00:00:00 2001 From: DimitarTachev Date: Fri, 18 Oct 2019 08:44:15 +0300 Subject: [PATCH] fix: do not require signing when the aab will not be deployed by the CLI --- lib/commands/build.ts | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/lib/commands/build.ts b/lib/commands/build.ts index 4afff5e3bf..6cb8217524 100644 --- a/lib/commands/build.ts +++ b/lib/commands/build.ts @@ -1,4 +1,4 @@ -import { ANDROID_RELEASE_BUILD_ERROR_MESSAGE, AndroidAppBundleMessages, ANDROID_APP_BUNDLE_SIGNING_ERROR_MESSAGE } from "../constants"; +import { ANDROID_RELEASE_BUILD_ERROR_MESSAGE, AndroidAppBundleMessages } from "../constants"; import { ValidatePlatformCommandBase } from "./command-base"; import { hasValidAndroidSigning } from "../common/helpers"; @@ -124,12 +124,8 @@ export class BuildAndroidCommand extends BuildCommandBase implements ICommand { this.$androidBundleValidatorHelper.validateRuntimeVersion(this.$projectData); let canExecute = await super.canExecuteCommandBase(platform, { notConfiguredEnvOptions: { hideSyncToPreviewAppOption: true } }); if (canExecute) { - if ((this.$options.release || this.$options.aab) && !hasValidAndroidSigning(this.$options)) { - if (this.$options.release) { - this.$errors.failWithHelp(ANDROID_RELEASE_BUILD_ERROR_MESSAGE); - } else { - this.$errors.failWithHelp(ANDROID_APP_BUNDLE_SIGNING_ERROR_MESSAGE); - } + if (this.$options.release && !hasValidAndroidSigning(this.$options)) { + this.$errors.failWithHelp(ANDROID_RELEASE_BUILD_ERROR_MESSAGE); } canExecute = await super.validateArgs(args, platform);