From 45f1870a0af0c8503c09b3caaeb761d22cc8e566 Mon Sep 17 00:00:00 2001 From: fatme Date: Tue, 15 Oct 2019 08:02:27 +0300 Subject: [PATCH 1/2] fix: pass allowProvisioningUpdates to xcodebuild only when building for device The `-allowProvisioningUpdates` option is passed to `xcodebuild` no matter if building for device or for simulator. According to the documentation of `xcodebuild`: ``` Allow xcodebuild to communicate with the Apple Developer website. For automatically signed targets, xcodebuild will create and update profiles, app IDs, and certificates. For manually signed targets, xcodebuild will download missing or updated provisioning profiles. Requires a developer account to have been added in Xcode's Accounts preference pane. ``` It seems it shouldn't be passed when building for simulator. --- lib/services/ios/xcodebuild-args-service.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/services/ios/xcodebuild-args-service.ts b/lib/services/ios/xcodebuild-args-service.ts index 8471d58873..c06dc65918 100644 --- a/lib/services/ios/xcodebuild-args-service.ts +++ b/lib/services/ios/xcodebuild-args-service.ts @@ -48,7 +48,8 @@ export class XcodebuildArgsService implements IXcodebuildArgsService { const args = [ "archive", "-archivePath", archivePath, - "-configuration", buildConfig.release ? Configurations.Release : Configurations.Debug + "-configuration", buildConfig.release ? Configurations.Release : Configurations.Debug, + '-allowProvisioningUpdates' ] .concat(this.getXcodeProjectArgs(platformData.projectRoot, projectData, ProductArgs.scheme)) .concat(architectures) @@ -92,8 +93,7 @@ export class XcodebuildArgsService implements IXcodebuildArgsService { args = args.concat([ "BUILD_DIR=" + path.join(platformData.projectRoot, constants.BUILD_DIR), - 'SHARED_PRECOMPS_DIR=' + path.join(platformData.projectRoot, 'build', 'sharedpch'), - '-allowProvisioningUpdates' + 'SHARED_PRECOMPS_DIR=' + path.join(platformData.projectRoot, constants.BUILD_DIR, 'sharedpch') ]); return args; From e051ea1c95cfe5e6c4680b515243321742264328 Mon Sep 17 00:00:00 2001 From: fatme Date: Tue, 15 Oct 2019 08:15:22 +0300 Subject: [PATCH 2/2] chore: fix unit tests --- test/services/ios/xcodebuild-args-service.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/services/ios/xcodebuild-args-service.ts b/test/services/ios/xcodebuild-args-service.ts index 8a284347e0..96a6076c5f 100644 --- a/test/services/ios/xcodebuild-args-service.ts +++ b/test/services/ios/xcodebuild-args-service.ts @@ -33,7 +33,6 @@ function getCommonArgs() { return [ "BUILD_DIR=" + path.join(projectRoot, "build"), "SHARED_PRECOMPS_DIR=" + path.join(projectRoot, 'build', 'sharedpch'), - "-allowProvisioningUpdates" ]; } @@ -119,7 +118,8 @@ describe("xcodebuildArgsService", () => { const expectedArgs = [ "archive", "-archivePath", path.join(buildOutputPath, `${projectName}.xcarchive`), - "-configuration", configuration + "-configuration", configuration, + "-allowProvisioningUpdates" ] .concat(getXcodeProjectArgs({ hasProjectWorkspace })) .concat(testCase.expectedArgs)