Skip to content

fix: missing --template arg #4901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2019
Merged

fix: missing --template arg #4901

merged 1 commit into from
Jul 26, 2019

Conversation

rynop
Copy link
Contributor

@rynop rynop commented Jul 25, 2019

missing --template arg on create cmd examples.

This PR targets the release branch per #4900

@cla-bot cla-bot bot added the cla: yes label Jul 25, 2019
rosen-vladimirov
rosen-vladimirov approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work 🥇

@rosen-vladimirov
Copy link
Contributor

Thanks a lot for your contribution!

@rosen-vladimirov rosen-vladimirov merged commit a106c8d into NativeScript:release Jul 26, 2019
@rosen-vladimirov
Copy link
Contributor

Acceptance criteria:

  • tns create --help must show valid commands, i.e. the commands should do exactly what has been described and their arguments must be valid. The commands for creating apps from different templates must include --template option.
  • tns help create command must open html file in which the description how to create application from template contains --template flag.

@rynop rynop deleted the patch-2 branch July 26, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosen-vladimirov rosen-vladimirov rosen-vladimirov approved these changes

Assignees
No one assigned
Labels
cla: yes docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rynop @rosen-vladimirov