From 47484fd6f62e2292536af7da2a9964f051ed9e23 Mon Sep 17 00:00:00 2001 From: rosen-vladimirov Date: Wed, 10 Jul 2019 12:41:58 +0300 Subject: [PATCH] fix: `tns debug ios` should work on device Currently `tns debug ios` hangs when executed for device. The problem is that we pass `"waitForDebugger": false` to ios-device-lib binary, which can parse only strings. The value `false` is boolean, not string, so ios-device-lib binary crashes, but CLI does not understand this and hangs. Fix this by ensuring we pass waitForDebugger as string. --- lib/common/mobile/ios/device/ios-application-manager.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/common/mobile/ios/device/ios-application-manager.ts b/lib/common/mobile/ios/device/ios-application-manager.ts index 5c757de159..4e7d0bc44e 100644 --- a/lib/common/mobile/ios/device/ios-application-manager.ts +++ b/lib/common/mobile/ios/device/ios-application-manager.ts @@ -102,7 +102,7 @@ export class IOSApplicationManager extends ApplicationManagerBase { } private async runApplicationCore(appData: Mobile.IStartApplicationData): Promise { - const waitForDebugger = appData.waitForDebugger && appData.waitForDebugger.toString(); + const waitForDebugger = (!!appData.waitForDebugger).toString(); await this.$iosDeviceOperations.start([{ deviceId: this.device.deviceInfo.identifier, appId: appData.appId, ddi: this.$options.ddi, waitForDebugger }]); }