From 5a4591c839eb7e07491881aaaea2fc76379d665f Mon Sep 17 00:00:00 2001 From: rosen-vladimirov Date: Thu, 4 Jul 2019 11:16:08 +0300 Subject: [PATCH] fix: before-preview-sync hook has incorrect args The `before-preview-sync` hook has incorrect args - instead of having `hookArgs`, it has an object with data. This causes issues in all plugins which are using it. Get back the correct structure and add `projectData` as it is being used by kinvey-nativescript-sdk's hook. --- lib/controllers/preview-app-controller.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/controllers/preview-app-controller.ts b/lib/controllers/preview-app-controller.ts index cdd90f39de..41381e6305 100644 --- a/lib/controllers/preview-app-controller.ts +++ b/lib/controllers/preview-app-controller.ts @@ -25,7 +25,8 @@ export class PreviewAppController extends EventEmitter implements IPreviewAppCon private $previewDevicesService: IPreviewDevicesService, private $previewQrCodeService: IPreviewQrCodeService, private $previewSdkService: IPreviewSdkService, - private $prepareDataService: PrepareDataService + private $prepareDataService: PrepareDataService, + private $projectDataService: IProjectDataService ) { super(); } public async startPreview(data: IPreviewAppLiveSyncData): Promise { @@ -66,7 +67,8 @@ export class PreviewAppController extends EventEmitter implements IPreviewAppCon }); } - await this.$hooksService.executeBeforeHooks("preview-sync", { ...data, platform: device.platform }); + const projectData = this.$projectDataService.getProjectData(data.projectDir); + await this.$hooksService.executeBeforeHooks("preview-sync", { hookArgs: { ...data, platform: device.platform, projectData } }); if (data.useHotModuleReload) { this.$hmrStatusService.attachToHmrStatusEvent();