From c47a0fb2166a9fb1d8bd5b6cdba3eba5f6bcf68d Mon Sep 17 00:00:00 2001 From: Dimitar Topuzov Date: Fri, 15 Mar 2019 16:25:41 +0200 Subject: [PATCH 1/4] chore: add e2e test info in PR template Add info how to run e2e tests on PR. --- .github/PULL_REQUEST_TEMPLATE.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 2f56c9a5a9..c0785779f9 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -35,3 +35,17 @@ Migration steps: [Provide a migration path for existing applications.] --> + +## Need additional testing? +Additional e2e tests can be executed by comment including trigger phrase. + +Phrases: +`test cli-smoke`: Smoke tests for `tns run`. +`test cli-create`: Tests for `tns create` commans. +`test cli-plugin`: Tests for `tns plugin *` commands. +`cli-preview`: Tests for `tns preview` command. +`cli-regression`: Tests for backward compatibility with old projects. +`cli-resources`: Test for resource generate. +`cli-tests`: Tests for `tns test` command. +`cli-vue`: Smoke tests for VueJS projects based on {N} cli. +`cli-templates`: Tests for `tns run` on {N} templates. From 844f3b53e172fe6e36a1713bece75b377c8abce3 Mon Sep 17 00:00:00 2001 From: Dimitar Topuzov Date: Fri, 15 Mar 2019 16:28:33 +0200 Subject: [PATCH 2/4] chore: place e2e test info in comment --- .github/PULL_REQUEST_TEMPLATE.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index c0785779f9..cb034c087f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -36,7 +36,9 @@ Migration steps: --> -## Need additional testing? + From 84f8c7d5254b8ca7aa188e32d49c3ea21fc1c84d Mon Sep 17 00:00:00 2001 From: Dimitar Topuzov Date: Fri, 15 Mar 2019 16:41:12 +0200 Subject: [PATCH 3/4] chore: add note for PRs against release branch --- .github/PULL_REQUEST_TEMPLATE.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index cb034c087f..90ae39e9c6 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -51,4 +51,9 @@ Phrases: `cli-tests`: Tests for `tns test` command. `cli-vue`: Smoke tests for VueJS projects based on {N} cli. `cli-templates`: Tests for `tns run` on {N} templates. + +Notes: +If PR is against release branch additional comment should be added: +`test package_version#` (for example `test package_version#latest`) +This will tell what version of other packages will be used in tests. --> From 6dbdd7f2f2bba12e80da251e8a2cf4f1ddd40263 Mon Sep 17 00:00:00 2001 From: Dimitar Topuzov Date: Mon, 18 Mar 2019 10:59:22 +0200 Subject: [PATCH 4/4] fix: e2e descriptions --- .github/PULL_REQUEST_TEMPLATE.md | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 90ae39e9c6..b9354924af 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -45,15 +45,16 @@ Phrases: `test cli-smoke`: Smoke tests for `tns run`. `test cli-create`: Tests for `tns create` commans. `test cli-plugin`: Tests for `tns plugin *` commands. -`cli-preview`: Tests for `tns preview` command. -`cli-regression`: Tests for backward compatibility with old projects. -`cli-resources`: Test for resource generate. -`cli-tests`: Tests for `tns test` command. -`cli-vue`: Smoke tests for VueJS projects based on {N} cli. -`cli-templates`: Tests for `tns run` on {N} templates. - -Notes: -If PR is against release branch additional comment should be added: -`test package_version#` (for example `test package_version#latest`) -This will tell what version of other packages will be used in tests. +`test cli-preview`: Tests for `tns preview` command. +`test cli-regression`: Tests for backward compatibility with old projects. +`test cli-resources`: Test for resource generate. +`test cli-tests`: Tests for `tns test` command. +`test cli-vue`: Smoke tests for VueJS projects based on {N} cli. +`test cli-templates`: Tests for `tns run` on {N} templates. + +Define other packages used in e2e tests: + +- If PR targets master branch e2e tests will take runtimes and modules @next. +- If PR targets release branch e2e tests will take runtimes and modules @rc. +- You can control version of other packages used in e2e test by adding `package_version#` as param in trigger phrase (for example `test package_version#latest`). -->