From 5acd208ac0a0c9bc62aad78bfe94df226a2c4e7a Mon Sep 17 00:00:00 2001 From: Dimitar Topuzov Date: Tue, 3 Jul 2018 06:19:21 -0700 Subject: [PATCH 1/3] fix: xcode10 build `tns build ios --release --for-device` fails with Xcode 10 beta 2. This should fix it. --- lib/services/ios-project-service.ts | 4 ++++ test/ios-project-service.ts | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/lib/services/ios-project-service.ts b/lib/services/ios-project-service.ts index cebfa0ded5..cb42e4fa7b 100644 --- a/lib/services/ios-project-service.ts +++ b/lib/services/ios-project-service.ts @@ -257,6 +257,8 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ plistTemplate += ` method app-store uploadBitcode + + compileBitcode uploadSymbols @@ -303,6 +305,8 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ } plistTemplate += ` uploadBitcode + + compileBitcode `; diff --git a/test/ios-project-service.ts b/test/ios-project-service.ts index 16aca624d1..a9b76c03c9 100644 --- a/test/ios-project-service.ts +++ b/test/ios-project-service.ts @@ -232,6 +232,8 @@ describe("iOSProjectService", () => { method app-store uploadBitcode + + compileBitcode uploadSymbols @@ -247,6 +249,8 @@ describe("iOSProjectService", () => { method app-store uploadBitcode + + compileBitcode uploadSymbols From 96df6a1dda9397e76f18004da476e7504cd10392 Mon Sep 17 00:00:00 2001 From: Dimitar Topuzov Date: Wed, 4 Jul 2018 01:30:58 -0700 Subject: [PATCH 2/3] fix: formating --- lib/services/ios-project-service.ts | 8 ++++---- test/ios-project-service.ts | 10 +++++----- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/services/ios-project-service.ts b/lib/services/ios-project-service.ts index cb42e4fa7b..9a040aca55 100644 --- a/lib/services/ios-project-service.ts +++ b/lib/services/ios-project-service.ts @@ -257,9 +257,9 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ plistTemplate += ` method app-store uploadBitcode - - compileBitcode + compileBitcode + uploadSymbols @@ -305,8 +305,8 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ } plistTemplate += ` uploadBitcode - - compileBitcode + + compileBitcode `; diff --git a/test/ios-project-service.ts b/test/ios-project-service.ts index a9b76c03c9..94e7805847 100644 --- a/test/ios-project-service.ts +++ b/test/ios-project-service.ts @@ -229,11 +229,11 @@ describe("iOSProjectService", () => { - method +method app-store uploadBitcode - - compileBitcode + + compileBitcode uploadSymbols @@ -249,8 +249,8 @@ describe("iOSProjectService", () => { method app-store uploadBitcode - - compileBitcode + + compileBitcode uploadSymbols From f6225cc90c03201803a111d3774e6fe042ba7b3d Mon Sep 17 00:00:00 2001 From: Dimitar Topuzov Date: Wed, 4 Jul 2018 01:35:26 -0700 Subject: [PATCH 3/3] fix: formating --- lib/services/ios-project-service.ts | 2 +- test/ios-project-service.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/services/ios-project-service.ts b/lib/services/ios-project-service.ts index 9a040aca55..59a11b60a5 100644 --- a/lib/services/ios-project-service.ts +++ b/lib/services/ios-project-service.ts @@ -259,7 +259,7 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ uploadBitcode compileBitcode - + uploadSymbols diff --git a/test/ios-project-service.ts b/test/ios-project-service.ts index 94e7805847..54b8d2ae00 100644 --- a/test/ios-project-service.ts +++ b/test/ios-project-service.ts @@ -229,7 +229,7 @@ describe("iOSProjectService", () => { -method + method app-store uploadBitcode