From d17fd9459568fa39f9ef4a241dc50c40bc8c5a66 Mon Sep 17 00:00:00 2001 From: rosen-vladimirov Date: Fri, 22 Jun 2018 16:52:07 +0300 Subject: [PATCH] fix(unit-testing): Fix tests executed with jasmine MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Trying to execute execute tests with jasmine fails, as during initialization we have written incorrect data in karma.config.js file. The error is: `Error: No provider for “framework:undefined”! (Resolving: framework:undefined)` The problem is that during initalization we set undefined for framework value. Fix the initalization code to enter correct data in karma.config.js --- lib/commands/test-init.ts | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/lib/commands/test-init.ts b/lib/commands/test-init.ts index e1e0adc9d2..10099c9461 100644 --- a/lib/commands/test-init.ts +++ b/lib/commands/test-init.ts @@ -101,12 +101,11 @@ class TestInitCommand implements ICommand { this.$fs.ensureDirectoryExists(testsDir); + const frameworks = [frameworkToInstall].concat(this.karmaConfigAdditionalFrameworks[frameworkToInstall] || []) + .map(fw => `'${fw}'`) + .join(', '); const karmaConfTemplate = this.$resources.readText('test/karma.conf.js'); - const karmaConf = _.template(karmaConfTemplate)({ - frameworks: [frameworkToInstall].concat(this.karmaConfigAdditionalFrameworks[frameworkToInstall]) - .map(fw => `'${fw}'`) - .join(', ') - }); + const karmaConf = _.template(karmaConfTemplate)({ frameworks }); this.$fs.writeFile(path.join(projectDir, 'karma.conf.js'), karmaConf);