chore: remove unused dep, add back doctor types, use * for version in tests

Author: rigor789

package.json

@@ -163,7 +163,6 @@
     "latest-version": "5.1.0",
     "lint-staged": "^13.2.0",
     "mocha": "10.2.0",
-    "should": "13.2.3",
     "sinon": "15.0.2",
     "source-map-support": "0.5.21"
   },

packages/doctor/typings/nativescript-doctor.d.ts

@@ -1,9 +1,9 @@
-// /// <reference path="./interfaces.ts" />
+/// <reference path="./interfaces.ts" />
 
-// declare module "@nativescript/doctor" {
-// 	export const doctor: NativeScriptDoctor.IDoctor;
-// 	export const sysInfo: NativeScriptDoctor.ISysInfo;
-// 	export const constants: NativeScriptDoctor.IConstants;
-// 	export const androidToolsInfo: NativeScriptDoctor.IAndroidToolsInfo;
-// 	export const setShouldCacheSysInfo: (shouldCache: boolean) => void;
-// }
+declare module "@nativescript/doctor" {
+	export const doctor: NativeScriptDoctor.IDoctor;
+	export const sysInfo: NativeScriptDoctor.ISysInfo;
+	export const constants: NativeScriptDoctor.IConstants;
+	export const androidToolsInfo: NativeScriptDoctor.IAndroidToolsInfo;
+	export const setShouldCacheSysInfo: (shouldCache: boolean) => void;
+}

test/definitions/should.d.ts

@@ -294,9 +294,8 @@ async function addPluginWhenExpectingToFail(
 ) {
 	createProjectFile(testInjector);
 
-	const pluginsService: IPluginsService = testInjector.resolve(
-		"pluginsService"
-	);
+	const pluginsService: IPluginsService =
+		testInjector.resolve("pluginsService");
 	pluginsService.getAllInstalledPlugins = async (projectData: IProjectData) => {
 		return <any[]>[{ name: "" }];
 	};
@@ -352,9 +351,8 @@ describe("Plugins service", () => {
 				projectData.dependencies[pluginName] = "^1.0.0";
 				fs.writeJson(projectFilePath, projectData);
 
-				const pluginsService: IPluginsService = testInjector.resolve(
-					"pluginsService"
-				);
+				const pluginsService: IPluginsService =
+					testInjector.resolve("pluginsService");
 				pluginsService.getAllInstalledPlugins = async (
 					projData: IProjectData
 				) => {
@@ -413,9 +411,8 @@ describe("Plugins service", () => {
 				};
 
 				// Mock pluginsService
-				const pluginsService: IPluginsService = testInjector.resolve(
-					"pluginsService"
-				);
+				const pluginsService: IPluginsService =
+					testInjector.resolve("pluginsService");
 				const projectData: IProjectData = testInjector.resolve("projectData");
 				projectData.initializeProjectData();
 				pluginsService.getAllInstalledPlugins = async (
@@ -458,9 +455,8 @@ describe("Plugins service", () => {
 				const pluginName = "plugin1";
 				const projectFolder = createProjectFile(testInjector);
 
-				const pluginsService: IPluginsService = testInjector.resolve(
-					"pluginsService"
-				);
+				const pluginsService: IPluginsService =
+					testInjector.resolve("pluginsService");
 				pluginsService.getAllInstalledPlugins = async (
 					projectData: IProjectData
 				) => {
@@ -502,9 +498,8 @@ describe("Plugins service", () => {
 				const pluginName = "plugin1";
 				const projectFolder = createProjectFile(testInjector);
 
-				const pluginsService: IPluginsService = testInjector.resolve(
-					"pluginsService"
-				);
+				const pluginsService: IPluginsService =
+					testInjector.resolve("pluginsService");
 				pluginsService.getAllInstalledPlugins = async (
 					projectData: IProjectData
 				) => {
@@ -560,9 +555,8 @@ describe("Plugins service", () => {
 					pluginJsonData
 				);
 
-				const pluginsService: IPluginsService = testInjector.resolve(
-					"pluginsService"
-				);
+				const pluginsService: IPluginsService =
+					testInjector.resolve("pluginsService");
 				pluginsService.getAllInstalledPlugins = async (
 					projectData: IProjectData
 				) => {
@@ -610,9 +604,8 @@ describe("Plugins service", () => {
 					pluginJsonData
 				);
 
-				const pluginsService: IPluginsService = testInjector.resolve(
-					"pluginsService"
-				);
+				const pluginsService: IPluginsService =
+					testInjector.resolve("pluginsService");
 				pluginsService.getAllInstalledPlugins = async (
 					projectData: IProjectData
 				) => {
@@ -652,10 +645,10 @@ describe("Plugins service", () => {
 						platforms: {},
 					},
 					dependencies: {
-						lodash: "3.8.0",
+						lodash: "*",
 					},
 					devDependencies: {
-						grunt: "0.4.2",
+						grunt: "*",
 					},
 				};
 				const fs = testInjector.resolve("fs");
@@ -664,9 +657,8 @@ describe("Plugins service", () => {
 					pluginJsonData
 				);
 
-				const pluginsService: IPluginsService = testInjector.resolve(
-					"pluginsService"
-				);
+				const pluginsService: IPluginsService =
+					testInjector.resolve("pluginsService");
 				pluginsService.getAllInstalledPlugins = async (
 					projectData: IProjectData
 				) => {
@@ -765,9 +757,8 @@ describe("Plugins service", () => {
 			unitTestsInjector.register("nodeModulesDependenciesBuilder", {});
 			unitTestsInjector.register("tempService", stubs.TempServiceStub);
 
-			const pluginsService: PluginsService = unitTestsInjector.resolve(
-				PluginsService
-			);
+			const pluginsService: PluginsService =
+				unitTestsInjector.resolve(PluginsService);
 			testData.pluginsService = pluginsService;
 			testData.pluginData = samplePluginData;
 			return testData;
@@ -858,9 +849,8 @@ describe("Plugins service", () => {
 
 		it("returns correct pluginData", () => {
 			const unitTestsInjector = createUnitTestsInjector();
-			const pluginsService: PluginsService = unitTestsInjector.resolve(
-				PluginsService
-			);
+			const pluginsService: PluginsService =
+				unitTestsInjector.resolve(PluginsService);
 			const pluginData = (<any>pluginsService).convertToPluginData(
 				dataFromPluginPackageJson,
 				"my project dir"
@@ -879,9 +869,8 @@ describe("Plugins service", () => {
 
 		it("always returns lowercased platform in the path to plugins dir", () => {
 			const unitTestsInjector = createUnitTestsInjector();
-			const pluginsService: PluginsService = unitTestsInjector.resolve(
-				PluginsService
-			);
+			const pluginsService: PluginsService =
+				unitTestsInjector.resolve(PluginsService);
 			const pluginData = (<any>pluginsService).convertToPluginData(
 				dataFromPluginPackageJson,
 				"my project dir"
@@ -1179,9 +1168,8 @@ This framework comes from nativescript-ui-core plugin, which is installed multip
 		for (const testCase of testCases) {
 			it(testCase.testName, () => {
 				const unitTestsInjector: IInjector = createUnitTestsInjector();
-				const pluginsService: IPluginsService = unitTestsInjector.resolve(
-					PluginsService
-				);
+				const pluginsService: IPluginsService =
+					unitTestsInjector.resolve(PluginsService);
 
 				if (testCase.expectedOutput instanceof Error) {
 					assert.throws(
@@ -1201,9 +1189,8 @@ This framework comes from nativescript-ui-core plugin, which is installed multip
 					);
 
 					if (testCase.expectedWarning) {
-						const logger = unitTestsInjector.resolve<stubs.LoggerStub>(
-							"logger"
-						);
+						const logger =
+							unitTestsInjector.resolve<stubs.LoggerStub>("logger");
 						assert.equal(testCase.expectedWarning + "\n", logger.warnOutput);
 					}
 
@@ -1221,9 +1208,8 @@ This framework comes from nativescript-ui-core plugin, which is installed multip
 
 		it(`caches result based on dependencies`, () => {
 			const unitTestsInjector: IInjector = createUnitTestsInjector();
-			const pluginsService: IPluginsService = unitTestsInjector.resolve(
-				PluginsService
-			);
+			const pluginsService: IPluginsService =
+				unitTestsInjector.resolve(PluginsService);
 			const inputDependencies = [
 				{
 					name: "nativescript-ui-core",