Skip to content

Commit f1b58ba

Browse files
committed
fix: do not require migration when file references or tags are used as dependencies
1 parent c978bcf commit f1b58ba

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

lib/controllers/migrate-controller.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -356,11 +356,11 @@ Running this command will ${MigrateController.COMMON_MIGRATE_MESSAGE}`;
356356
const devDependencies = projectData.devDependencies || {};
357357
const dependencies = projectData.dependencies || {};
358358
const packageName = dependency.packageName;
359-
const version = dependencies[packageName] || devDependencies[packageName];
360-
const maxSatisfyingVersion = await this.getMaxDependencyVersion(dependency.packageName, version);
361-
const dependencyVersion = await this.getDependencyVerifiedVersion(dependency, projectData);
359+
const referencedVersion = dependencies[packageName] || devDependencies[packageName];
360+
const installedVersion = await this.getMaxDependencyVersion(dependency.packageName, referencedVersion);
361+
const requiredVersion = await this.getDependencyVerifiedVersion(dependency, projectData);
362362

363-
return !(maxSatisfyingVersion && semver.gte(maxSatisfyingVersion, dependencyVersion));
363+
return !!installedVersion && semver.lt(installedVersion, requiredVersion);
364364
}
365365

366366
protected async shouldUpdateRuntimeVersion({ targetVersion, platform, projectData }: { targetVersion: string, platform: string, projectData: IProjectData }): Promise<boolean> {

0 commit comments

Comments
 (0)