Skip to content

Commit ebaab3c

Browse files
fix: print information message when package-manager is set
Currently when calling `tns package-manager set <valid value>` you do not see any output or information if the operation is successful. Add such message and clean the code from hardcoded strings.
1 parent 9e037f8 commit ebaab3c

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

lib/common/commands/package-manager-set.ts

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,24 @@
1+
import { PackageManagers } from "../../constants";
12

23
export class PackageManagerCommand implements ICommand {
34

45
constructor(private $userSettingsService: IUserSettingsService,
56
private $errors: IErrors,
7+
private $logger: ILogger,
68
private $stringParameter: ICommandParameter) { }
79

810
public allowedParameters: ICommandParameter[] = [this.$stringParameter];
911

10-
public execute(args: string[]): Promise<void> {
11-
if (args[0] === 'yarn') {
12-
return this.$userSettingsService.saveSetting("packageManager", "yarn");
13-
} else if (args[0] === 'pnpm') {
14-
return this.$userSettingsService.saveSetting("packageManager", "pnpm");
15-
} else if (args[0] === 'npm') {
16-
return this.$userSettingsService.saveSetting("packageManager", "npm");
12+
public async execute(args: string[]): Promise<void> {
13+
const packageManagerName = args[0];
14+
const supportedPackageManagers = Object.keys(PackageManagers);
15+
if (supportedPackageManagers.indexOf(packageManagerName) === -1) {
16+
this.$errors.fail(`${packageManagerName} is not a valid package manager. Supported values are: ${supportedPackageManagers.join(", ")}.`);
1717
}
18-
return this.$errors.fail(`${args[0]} is not a valid package manager. Only yarn or npm are supported.`);
18+
19+
await this.$userSettingsService.saveSetting("packageManager", packageManagerName);
20+
21+
this.$logger.printMarkdown(`You've successfully set \`${packageManagerName}\` as your package manager.`);
1922
}
2023
}
2124

0 commit comments

Comments
 (0)