Skip to content

Commit e44029f

Browse files
refactor(help-service): Extract methods instead of duplicating code
1 parent 069b3e7 commit e44029f

File tree

2 files changed

+3
-14
lines changed

2 files changed

+3
-14
lines changed

lib/services/extensibility-service.ts

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,7 @@ export class ExtensibilityService implements IExtensibilityService {
3535
const installResultInfo = await this.$npm.install(packageName, this.pathToExtensions, npmOpts);
3636
this.$logger.trace(`Finished installation of extension '${extensionName}'. Trying to load it now.`);
3737

38-
const packageJsonData = this.getExtensionPackageJsonData(installResultInfo.name);
39-
40-
const pathToExtension = this.getPathToExtension(extensionName);
41-
const docs = packageJsonData && packageJsonData.nativescript && packageJsonData.nativescript.docs && path.join(pathToExtension, packageJsonData.nativescript.docs);
42-
return {
43-
extensionName: installResultInfo.name,
44-
version: installResultInfo.version,
45-
docs,
46-
pathToExtension
47-
};
38+
return this.getInstalledExtensionData(installResultInfo.name);
4839
}
4940

5041
@exported("extensibilityService")
@@ -60,9 +51,7 @@ export class ExtensibilityService implements IExtensibilityService {
6051

6152
public getInstalledExtensionsData(): IExtensionData[] {
6253
const installedExtensions = this.getInstalledExtensions();
63-
return _.keys(installedExtensions).map(installedExtension => {
64-
return this.getInstalledExtensionData(installedExtension);
65-
});
54+
return _.keys(installedExtensions).map(installedExtension => this.getInstalledExtensionData(installedExtension));
6655
}
6756

6857
@exported("extensibilityService")

0 commit comments

Comments
 (0)