Merge pull request #4578 from NativeScript/fatme/deprecated-messages

feat: show deprecated messages for things that will be dropped as of NativeScript v.6.0.0

Author: Fatme

lib/commands/clean-app.ts

@@ -10,12 +10,15 @@ export class CleanAppCommandBase extends ValidatePlatformCommandBase implements
 		$platformService: IPlatformService,
 		protected $errors: IErrors,
 		protected $devicePlatformsConstants: Mobile.IDevicePlatformsConstants,
-		$platformsData: IPlatformsData) {
+		$platformsData: IPlatformsData,
+		private $logger: ILogger) {
 			super($options, $platformsData, $platformService, $projectData);
 			this.$projectData.initializeProjectData();
 	}
 
 	public async execute(args: string[]): Promise<void> {
+		this.$logger.warn(`"tns clean-app ${this.platform.toLowerCase()}" command has been deprecated and will be removed in the upcoming NativeScript CLI v6.0.0. More info can be found in this issue https://github.com/NativeScript/nativescript-cli/issues/4518.`);
+
 		const appFilesUpdaterOptions: IAppFilesUpdaterOptions = {
 			bundle: !!this.$options.bundle,
 			release: this.$options.release,
@@ -49,8 +52,9 @@ export class CleanAppIosCommand extends CleanAppCommandBase implements ICommand
 		protected $platformsData: IPlatformsData,
 		protected $errors: IErrors,
 		$platformService: IPlatformService,
-		$projectData: IProjectData) {
-		super($options, $projectData, $platformService, $errors, $devicePlatformsConstants, $platformsData);
+		$projectData: IProjectData,
+		$logger: ILogger) {
+		super($options, $projectData, $platformService, $errors, $devicePlatformsConstants, $platformsData, $logger);
 	}
 
 	protected get platform(): string {
@@ -66,8 +70,9 @@ export class CleanAppAndroidCommand extends CleanAppCommandBase implements IComm
 		protected $platformsData: IPlatformsData,
 		protected $errors: IErrors,
 		$platformService: IPlatformService,
-		$projectData: IProjectData) {
-		super($options, $projectData, $platformService, $errors, $devicePlatformsConstants, $platformsData);
+		$projectData: IProjectData,
+		$logger: ILogger) {
+		super($options, $projectData, $platformService, $errors, $devicePlatformsConstants, $platformsData, $logger);
 	}
 
 	protected get platform(): string {

lib/common/services/commands-service.ts

@@ -37,6 +37,7 @@ export class CommandsService implements ICommandsService {
 			}
 
 			this.$options.setupOptions(projectData);
+			this.$options.printMessagesForDeprecatedOptions(this.$logger);
 	}
 
 	public allCommands(opts: { includeDevCommands: boolean }): string[] {

lib/declarations.d.ts

@@ -569,9 +569,10 @@ interface IOptions extends IRelease, IDeviceIdentifier, IJustLaunch, IAvd, IAvai
 	link: boolean;
 	analyticsLogFile: string;
 	performance: Object;
-	setupOptions(projectData: IProjectData): void;
 	cleanupLogFile: string;
 	workflow: boolean;
+	setupOptions(projectData: IProjectData): void;
+	printMessagesForDeprecatedOptions(logger: ILogger): void;
 }
 
 interface IEnvOptions {

lib/options.ts

@@ -204,6 +204,21 @@ export class Options {
 		});
 	}
 
+	public printMessagesForDeprecatedOptions($logger: ILogger) {
+		if (this.argv.platformTemplate) {
+			$logger.warn(`"--platformTemplate" option has been deprecated and will be removed in the upcoming NativeScript CLI v6.0.0. More info can be found in this issue https://github.com/NativeScript/nativescript-cli/issues/4518.`);
+		}
+
+		if (this.argv.syncAllFiles) {
+			$logger.warn(`"--syncAllFiles" option has been deprecated and will be removed in the upcoming NativeScript CLI v6.0.0. More info can be found in this issue https://github.com/NativeScript/nativescript-cli/issues/4518.`);
+		}
+
+		if (this.argv.bundle) {
+			$logger.warn(`"--bundle" option has been deprecated and as of NativeScript CLI v6.0.0 Webpack workflow will become the only way of building apps.
+				More info about the reasons for this change and how to migrate your project can be found in the link below: <TODO: add link here>`);
+		}
+	}
+
 	private getCorrectOptionName(optionName: string): string {
 		const secondaryOptionName = this.getNonDashedOptionName(optionName);
 		return _.includes(this.optionNames, secondaryOptionName) ? secondaryOptionName : optionName;

lib/services/platform-service.ts

@@ -319,6 +319,11 @@ export class PlatformService extends EventEmitter implements IPlatformService {
 		this.$logger.out("Preparing project...");
 
 		const platformData = this.$platformsData.getPlatformData(platform, projectData);
+		const frameworkVersion = this.getCurrentPlatformVersion(platform, projectData);
+		if (semver.lt(semver.coerce(frameworkVersion), semver.coerce('5.1.0'))) {
+			this.$logger.warn(`Runtime versions lower than 5.1.0 have been deprecated and will not be supported as of v6.0.0 of NativeScript CLI. More info can be found in this issue https://github.com/NativeScript/nativescript-cli/issues/4518.`);
+		}
+
 		const projectFilesConfig = helpers.getProjectFilesConfig({ isReleaseBuild: appFilesUpdaterOptions.release });
 		await this.$preparePlatformJSService.preparePlatform({
 			platform,

test/platform-service.ts

@@ -516,6 +516,7 @@ describe('Platform Service Tests', () => {
 
 			platformService = testInjector.resolve("platformService");
 			const appFilesUpdaterOptions: IAppFilesUpdaterOptions = { bundle: false, release: release, useHotModuleReload: false };
+			platformService.getCurrentPlatformVersion = () => "5.1.1";
 			await platformService.preparePlatform({
 				platform: platformToTest,
 				appFilesUpdaterOptions,
@@ -950,6 +951,7 @@ describe('Platform Service Tests', () => {
 			projectData.appResourcesDirectoryPath = projectData.getAppResourcesDirectoryPath();
 
 			platformService = testInjector.resolve("platformService");
+			platformService.getCurrentPlatformVersion = () => "5.1.1";
 			const oldLoggerWarner = testInjector.resolve("$logger").warn;
 			let warnings: string = "";
 			try {