Skip to content

Commit b1101cc

Browse files
feat(analytics): Remove tracking in cross-client project
We are no longer using the cross clients analytics project, so delete the code that sends information to it.
1 parent 5253501 commit b1101cc

File tree

1 file changed

+5
-28
lines changed

1 file changed

+5
-28
lines changed

lib/services/analytics/google-analytics-provider.ts

Lines changed: 5 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { AnalyticsClients } from "../../common/constants";
44

55
export class GoogleAnalyticsProvider implements IGoogleAnalyticsProvider {
66
private static GA_TRACKING_ID = "UA-111455-44";
7-
private static GA_CROSS_CLIENT_TRACKING_ID = "UA-111455-51";
87
private currentPage: string;
98

109
constructor(private clientId: string,
@@ -15,15 +14,12 @@ export class GoogleAnalyticsProvider implements IGoogleAnalyticsProvider {
1514
}
1615

1716
public async trackHit(trackInfo: IGoogleAnalyticsData): Promise<void> {
18-
const trackingIds = [GoogleAnalyticsProvider.GA_TRACKING_ID, GoogleAnalyticsProvider.GA_CROSS_CLIENT_TRACKING_ID];
1917
const sessionId = uuid.v4();
2018

21-
for (const gaTrackingId of trackingIds) {
22-
try {
23-
await this.track(gaTrackingId, trackInfo, sessionId);
24-
} catch (e) {
25-
this.$logger.trace("Analytics exception: ", e);
26-
}
19+
try {
20+
await this.track(GoogleAnalyticsProvider.GA_TRACKING_ID, trackInfo, sessionId);
21+
} catch (e) {
22+
this.$logger.trace("Analytics exception: ", e);
2723
}
2824
}
2925

@@ -41,14 +37,7 @@ export class GoogleAnalyticsProvider implements IGoogleAnalyticsProvider {
4137
}
4238
});
4339

44-
switch (gaTrackingId) {
45-
case GoogleAnalyticsProvider.GA_CROSS_CLIENT_TRACKING_ID:
46-
this.setCrossClientCustomDimensions(visitor, sessionId);
47-
break;
48-
default:
49-
await this.setCustomDimensions(visitor, trackInfo.customDimensions, sessionId);
50-
break;
51-
}
40+
await this.setCustomDimensions(visitor, trackInfo.customDimensions, sessionId);
5241

5342
switch (trackInfo.googleAnalyticsDataType) {
5443
case GoogleAnalyticsDataType.Page:
@@ -83,18 +72,6 @@ export class GoogleAnalyticsProvider implements IGoogleAnalyticsProvider {
8372
});
8473
}
8574

86-
private async setCrossClientCustomDimensions(visitor: ua.Visitor, sessionId: string): Promise<void> {
87-
const customDimensions: IStringDictionary = {
88-
[GoogleAnalyticsCrossClientCustomDimensions.sessionId]: sessionId,
89-
[GoogleAnalyticsCrossClientCustomDimensions.clientId]: this.clientId,
90-
[GoogleAnalyticsCrossClientCustomDimensions.crossClientId]: this.clientId,
91-
};
92-
93-
_.each(customDimensions, (value, key) => {
94-
visitor.set(key, value);
95-
});
96-
}
97-
9875
private trackEvent(visitor: ua.Visitor, trackInfo: IGoogleAnalyticsEventData): Promise<void> {
9976
return new Promise<void>((resolve, reject) => {
10077
visitor.event(trackInfo.category, trackInfo.action, trackInfo.label, trackInfo.value, { p: this.currentPage }, (err: Error) => {

0 commit comments

Comments
 (0)