Merge pull request #4663 from NativeScript/fatme/fix-crash-on-deploy

fix: fix the application crash on device on deploy command

Author: rosen-vladimirov

lib/commands/build.ts

@@ -18,6 +18,7 @@ export abstract class BuildCommandBase extends ValidatePlatformCommandBase {
 
 	public dashedOptions = {
 		watch: { type: OptionType.Boolean, default: false, hasSensitiveValue: false },
+		hmr: { type: OptionType.Boolean, default: false, hasSensitiveValue: false },
 	};
 
 	public async executeCore(args: string[]): Promise<string> {

lib/commands/deploy.ts

@@ -5,6 +5,10 @@ import { DeployCommandHelper } from "../helpers/deploy-command-helper";
 export class DeployOnDeviceCommand extends ValidatePlatformCommandBase implements ICommand {
 	public allowedParameters: ICommandParameter[] = [];
 
+	public dashedOptions = {
+		hmr: { type: OptionType.Boolean, default: false, hasSensitiveValue: false },
+	};
+
 	constructor($platformValidationService: IPlatformValidationService,
 		private $platformCommandParameter: ICommandParameter,
 		$options: IOptions,

lib/commands/prepare.ts

@@ -7,6 +7,7 @@ export class PrepareCommand extends ValidatePlatformCommandBase implements IComm
 
 	public dashedOptions = {
 		watch: { type: OptionType.Boolean, default: false, hasSensitiveValue: false },
+		hmr: { type: OptionType.Boolean, default: false, hasSensitiveValue: false },
 	};
 
 	constructor($options: IOptions,

lib/controllers/deploy-controller.ts

@@ -11,7 +11,8 @@ export class DeployController {
 		const { liveSyncInfo, deviceDescriptors } = data;
 
 		const executeAction = async (device: Mobile.IDevice) => {
-			const buildData = this.$buildDataService.getBuildData(liveSyncInfo.projectDir, device.deviceInfo.platform, liveSyncInfo);
+			const options = { ...liveSyncInfo, buildForDevice: !device.isEmulator };
+			const buildData = this.$buildDataService.getBuildData(liveSyncInfo.projectDir, device.deviceInfo.platform, options);
 			await this.$buildController.prepareAndBuild(buildData);
 			await this.$deviceInstallAppService.installOnDevice(device, buildData);
 		};