Skip to content

Commit 908e422

Browse files
committed
Merge pull request #579 from NativeScript/kerezov/default-client-options
Introduce default value for client option
2 parents d3f9dae + b05eff8 commit 908e422

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

lib/common

Submodule common updated 1 file

lib/options.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export class Options extends commonOptionsLibPath.OptionsBase {
1919
emulator: { type: OptionType.Boolean },
2020
symlink: { type: OptionType.Boolean },
2121
forDevice: { type: OptionType.Boolean },
22-
client: { type: OptionType.Boolean },
22+
client: { type: OptionType.Boolean, default: true},
2323
production: { type: OptionType.Boolean },
2424
keyStorePath: { type: OptionType.String },
2525
keyStorePassword: { type: OptionType.String,},

lib/services/ios-debug-service.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -193,13 +193,12 @@ class IOSDebugService implements IDebugService {
193193
}
194194

195195
public executeOpenDebuggerClient(): IFuture<void> {
196-
if (this.$options.client === false) {
197-
// NOTE: The --no-client has been specified. Otherwise its either false or undefined.
196+
if (this.$options.client) {
197+
return this.openDebuggingClient();
198+
} else {
198199
return (() => {
199200
this.$logger.info("Supressing debugging client.");
200201
}).future<void>()();
201-
} else {
202-
return this.openDebuggingClient();
203202
}
204203
}
205204

0 commit comments

Comments
 (0)