Skip to content

Commit 7362eb1

Browse files
NathanWalkerrigor789
authored andcommitted
chore: cleanup
1 parent 5e46471 commit 7362eb1

File tree

2 files changed

+1
-17
lines changed

2 files changed

+1
-17
lines changed

lib/services/project-service.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ export class ProjectService implements IProjectService {
1919
private $projectNameService: IProjectNameService,
2020
private $projectTemplatesService: IProjectTemplatesService,
2121
private $staticConfig: IStaticConfig,
22-
private $packageInstallationManager: IPackageInstallationManager,
2322
private $tempService: ITempService) { }
2423

2524
public async validateProjectName(opts: { projectName: string, force: boolean, pathToProject: string }): Promise<string> {
@@ -91,10 +90,6 @@ export class ProjectService implements IProjectService {
9190

9291
await this.ensureAppResourcesExist(projectDir);
9392

94-
if (!(templatePackageJsonContent && templatePackageJsonContent.dependencies && templatePackageJsonContent.dependencies[constants.TNS_CORE_MODULES_NAME])) {
95-
await this.addTnsCoreModules(projectDir);
96-
}
97-
9893
if (templateVersion === constants.TemplateVersions.v1) {
9994
this.mergeProjectAndTemplateProperties(projectDir, templatePackageJsonContent); // merging dependencies from template (dev && prod)
10095
this.removeMergedDependencies(projectDir, templatePackageJsonContent);
@@ -246,16 +241,5 @@ export class ProjectService implements IProjectService {
246241
private setAppId(projectDir: string, projectId: string): void {
247242
this.$projectDataService.setNSValue(projectDir, "id", projectId);
248243
}
249-
250-
@performanceLog()
251-
private async addTnsCoreModules(projectDir: string): Promise<void> {
252-
const projectFilePath = path.join(projectDir, this.$staticConfig.PROJECT_FILE_NAME);
253-
const packageJsonData = this.$fs.readJson(projectFilePath);
254-
255-
const version = await this.$packageInstallationManager.getLatestCompatibleVersion(constants.TNS_CORE_MODULES_NAME);
256-
packageJsonData.dependencies[constants.TNS_CORE_MODULES_NAME] = version;
257-
258-
this.$fs.writeJson(projectFilePath, packageJsonData);
259-
}
260244
}
261245
$injector.register("projectService", ProjectService);

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "nativescript",
33
"preferGlobal": true,
4-
"version": "6.8.0-rc.3",
4+
"version": "6.8.0-rc.4",
55
"author": "NativeScript <support@nativescript.org>",
66
"description": "Command-line interface for building NativeScript projects",
77
"bin": {

0 commit comments

Comments
 (0)