Skip to content

Commit 50ac37b

Browse files
author
Dimitar Tachev
authored
Merge pull request #4854 from NativeScript/tachev/support-node8-in-webpack
fix: support node <= 8.9.4 (lookbehind is supported only with the `harmony` flag)
2 parents 1277156 + c2b1448 commit 50ac37b

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

lib/services/webpack/webpack-compiler-service.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import * as path from "path";
22
import * as child_process from "child_process";
3+
import * as semver from "semver";
34
import { EventEmitter } from "events";
45
import { performanceLog } from "../../common/decorators";
56
import { WEBPACK_COMPILATION_COMPLETE } from "../../constants";
@@ -130,8 +131,10 @@ export class WebpackCompilerService extends EventEmitter implements IWebpackComp
130131
private async startWebpackProcess(platformData: IPlatformData, projectData: IProjectData, prepareData: IPrepareData): Promise<child_process.ChildProcess> {
131132
const envData = this.buildEnvData(platformData.platformNameLowerCase, projectData, prepareData);
132133
const envParams = this.buildEnvCommandLineParams(envData, platformData, prepareData);
134+
const additionalNodeArgs = semver.major(process.version) <= 8 ? ["--harmony"] : [];
133135

134136
const args = [
137+
...additionalNodeArgs,
135138
path.join(projectData.projectDir, "node_modules", "webpack", "bin", "webpack.js"),
136139
"--preserve-symlinks",
137140
`--config=${path.join(projectData.projectDir, "webpack.config.js")}`,

0 commit comments

Comments
 (0)