fix: unnecessary refresh before restart

Author: KristianDD

lib/definitions/livesync.d.ts

@@ -420,11 +420,12 @@ interface IAndroidLivesyncTool {
 	removeFiles(filePaths: string[]): Promise<boolean[]>;
 	/**
 	 * Sends doSyncOperation that will be handled by the runtime.
+	 * @param doRefresh - Indicates if the application should be restarted. Defaults to true.
 	 * @param operationId - The identifier of the operation
 	 * @param timeout - The timeout in milliseconds
 	 * @returns {Promise<void>}
 	 */
-	sendDoSyncOperation(operationId: string, timeout?: number): Promise<IAndroidLivesyncSyncOperationResult>;
+	sendDoSyncOperation(doRefresh: boolean, timeout?: number, operationId?: string): Promise<IAndroidLivesyncSyncOperationResult>;
 	/**
 	 * Generates new operation identifier.
 	 */

lib/services/livesync/android-device-livesync-sockets-service.ts

@@ -35,7 +35,8 @@ export class AndroidDeviceSocketsLiveSyncService extends DeviceLiveSyncServiceBa
 
 		if (liveSyncInfo.modifiedFilesData.length) {
 			const operationIdentifier = this.livesyncTool.generateOperationIdentifier();
-			const doSyncPromise = this.livesyncTool.sendDoSyncOperation(operationIdentifier);
+
+			const doSyncPromise = this.livesyncTool.sendDoSyncOperation(canExecuteFastSync, null, operationIdentifier);
 
 			const syncInterval : NodeJS.Timer = setInterval(() => {
 				if (this.livesyncTool.isOperationInProgress(operationIdentifier)) {

lib/services/livesync/android-livesync-tool.md

@@ -155,18 +155,19 @@ When called, sendDoSyncOperation will tell the runtime to execute a script that
 * Definition
 ```TypeScript
 /**
- * Sends doSyncOperation that will be handeled by the runtime.
+ * Sends doSyncOperation that will be handled by the runtime.
+ * @param doRefresh - Indicates if the application should be restarted. Defaults to true.
  * @param operationId - The identifier of the operation
- * @param timeout - The timeout in miliseconds
+ * @param timeout - The timeout in milliseconds
  * @returns {Promise<void>}
  */
-sendDoSyncOperation(operationId: string, timeout?: number): Promise<void>;
+sendDoSyncOperation(doRefresh: boolean, timeout?: number, operationId?: string): Promise<IAndroidLivesyncSyncOperationResult>;
 ```
 
 * Example:
 ```JavaScript
 const operationId = liveSyncTool.generateOperationIdentifier();
-await liveSyncTool.sendDoSyncOperation(operationId);
+await liveSyncTool.sendDoSyncOperation(true, 10000, operationId);
 ```
 
 ### Calling end

lib/services/livesync/android-livesync-tool.ts

@@ -12,6 +12,9 @@ const ERROR_REPORT = 1;
 const OPERATION_END_REPORT = 2;
 const OPERATION_END_NO_REFRESH_REPORT_CODE = 3;
 const REPORT_LENGTH = 1;
+const DO_REFRESH_LENGTH = 1;
+const DO_REFRESH = 1;
+const SKIP_REFRESH = 0;
 const SYNC_OPERATION_TIMEOUT = 60000;
 const TRY_CONNECT_TIMEOUT = 30000;
 const DEFAULT_LOCAL_HOST_ADDRESS = "127.0.0.1";
@@ -119,29 +122,34 @@ export class AndroidLivesyncTool implements IAndroidLivesyncTool {
 		return !!this.operationPromises[operationId];
 	}
 
-	public sendDoSyncOperation(operationId: string, timeout: number): Promise<IAndroidLivesyncSyncOperationResult> {
+	public sendDoSyncOperation(doRefresh = true , timeout?: number, operationId?: string): Promise<IAndroidLivesyncSyncOperationResult> {
 		const id = operationId || this.generateOperationIdentifier();
 		const operationPromise: Promise<IAndroidLivesyncSyncOperationResult> = new Promise((resolve: Function, reject: Function) => {
 			this.verifyActiveConnection(reject);
-
 			const message = `${DO_SYNC_OPERATION}${id}`;
+			const headerBuffer = Buffer.alloc(Buffer.byteLength(message) + DO_REFRESH_LENGTH);
 			const socketId = this.socketConnection.uid;
-			const hash = crypto.createHash("md5").update(message).digest();
+			const doRefreshCode = doRefresh ? DO_REFRESH : SKIP_REFRESH;
+			const offset = headerBuffer.write(message);
+
+			headerBuffer.writeUInt8(doRefreshCode, offset);
+			const hash = crypto.createHash("md5").update(headerBuffer).digest();
 
 			this.operationPromises[id] = {
 				resolve,
 				reject,
 				socketId
 			};
 
-			this.socketConnection.write(message);
+			this.socketConnection.write(headerBuffer);
 			this.socketConnection.write(hash);
 
+			timeout = timeout || SYNC_OPERATION_TIMEOUT;
 			setTimeout(() => {
 				if (this.isOperationInProgress(id)) {
 					this.handleSocketError(socketId, "Sync operation is taking too long");
 				}
-			}, SYNC_OPERATION_TIMEOUT);
+			}, timeout);
 		});
 
 		return operationPromise;