Skip to content

Commit 2923ff5

Browse files
committed
Update ws module version
In order to fix vulnerabilities problems we need to update the version of ws module - https://nodesecurity.io/check/nativescript
1 parent d849bf1 commit 2923ff5

File tree

4 files changed

+28
-147
lines changed

4 files changed

+28
-147
lines changed

lib/definitions/ws.d.ts

Lines changed: 0 additions & 134 deletions
This file was deleted.

lib/device-sockets/ios/socket-proxy-factory.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,10 @@ export class SocketProxyFactory extends EventEmitter implements ISocketProxyFact
103103
callback(true);
104104
}
105105
});
106-
server.on("connection", (webSocket) => {
106+
server.on("connection", (webSocket, req) => {
107107
const encoding = "utf16le";
108108

109-
const deviceSocket: net.Socket = (<any>webSocket.upgradeReq)["__deviceSocket"];
109+
const deviceSocket: net.Socket = (<any>req)["__deviceSocket"];
110110
const packets = new PacketStream();
111111
deviceSocket.pipe(packets);
112112

@@ -122,7 +122,7 @@ export class SocketProxyFactory extends EventEmitter implements ISocketProxyFact
122122
this.$logger.trace("Error on debugger deviceSocket", err);
123123
});
124124

125-
webSocket.on("message", (message, flags) => {
125+
webSocket.on("message", (message: string) => {
126126
const length = Buffer.byteLength(message, encoding);
127127
const payload = new Buffer(length + 4);
128128
payload.writeInt32BE(length, 0);

npm-shrinkwrap.json

Lines changed: 23 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
],
3232
"dependencies": {
3333
"@types/ora": "1.3.2",
34+
"@types/ws": "4.0.1",
3435
"bplist-parser": "0.1.0",
3536
"bufferpack": "0.0.6",
3637
"byline": "4.2.1",
@@ -79,7 +80,7 @@
7980
"universal-analytics": "0.4.15",
8081
"uuid": "3.0.1",
8182
"winreg": "0.0.17",
82-
"ws": "2.2.0",
83+
"ws": "5.1.0",
8384
"xcode": "https://github.com/NativeScript/node-xcode/archive/1.4.0.tar.gz",
8485
"xml2js": "0.4.19",
8586
"xmldom": "0.1.21",

0 commit comments

Comments
 (0)