Skip to content

Commit 073fa50

Browse files
author
Fatme
authored
Merge pull request #3488 from NativeScript/fatme/update-ws
Update ws module version
2 parents db1c5d4 + 13c2f45 commit 073fa50

File tree

5 files changed

+38
-153
lines changed

5 files changed

+38
-153
lines changed

lib/common

Submodule common updated 1 file

lib/definitions/ws.d.ts

Lines changed: 0 additions & 134 deletions
This file was deleted.

lib/device-sockets/ios/socket-proxy-factory.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,10 +103,10 @@ export class SocketProxyFactory extends EventEmitter implements ISocketProxyFact
103103
callback(true);
104104
}
105105
});
106-
server.on("connection", (webSocket) => {
106+
server.on("connection", (webSocket, req) => {
107107
const encoding = "utf16le";
108108

109-
const deviceSocket: net.Socket = (<any>webSocket.upgradeReq)["__deviceSocket"];
109+
const deviceSocket: net.Socket = (<any>req)["__deviceSocket"];
110110
const packets = new PacketStream();
111111
deviceSocket.pipe(packets);
112112

@@ -122,7 +122,7 @@ export class SocketProxyFactory extends EventEmitter implements ISocketProxyFact
122122
this.$logger.trace("Error on debugger deviceSocket", err);
123123
});
124124

125-
webSocket.on("message", (message, flags) => {
125+
webSocket.on("message", (message: string) => {
126126
const length = Buffer.byteLength(message, encoding);
127127
const payload = new Buffer(length + 4);
128128
payload.writeInt32BE(length, 0);

npm-shrinkwrap.json

Lines changed: 31 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
"mobile"
3131
],
3232
"dependencies": {
33-
"@types/ora": "1.3.2",
3433
"bplist-parser": "0.1.0",
3534
"bufferpack": "0.0.6",
3635
"byline": "4.2.1",
@@ -79,7 +78,7 @@
7978
"universal-analytics": "0.4.15",
8079
"uuid": "3.0.1",
8180
"winreg": "0.0.17",
82-
"ws": "2.2.0",
81+
"ws": "5.1.0",
8382
"xcode": "https://github.com/NativeScript/node-xcode/archive/1.4.0.tar.gz",
8483
"xml2js": "0.4.19",
8584
"xmldom": "0.1.21",
@@ -95,12 +94,14 @@
9594
"@types/color": "3.0.0",
9695
"@types/lockfile": "1.0.0",
9796
"@types/node": "6.0.61",
97+
"@types/ora": "1.3.3",
9898
"@types/qr-image": "3.2.0",
9999
"@types/request": "0.0.45",
100100
"@types/semver": "^5.3.31",
101101
"@types/sinon": "4.0.0",
102102
"@types/source-map": "0.5.0",
103103
"@types/universal-analytics": "0.4.1",
104+
"@types/ws": "4.0.1",
104105
"@types/xml2js": "^0.4.2",
105106
"chai": "4.0.2",
106107
"chai-as-promised": "7.0.0",

0 commit comments

Comments
 (0)