Skip to content

Commit 47d1e05

Browse files
committed
fix: hack webpack test not to fail because of issue in webpack plugin
1 parent 1c7ddd7 commit 47d1e05

File tree

3 files changed

+12
-0
lines changed

3 files changed

+12
-0
lines changed

tests/webpack/hello_world_js_tests.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,10 @@ def test_100_android_build_release_with_bundle_and_uglify(self):
150150

151151
@unittest.skipIf(CURRENT_OS != OSType.OSX, "Run only on macOS.")
152152
def test_100_ios_build_release_with_bundle_and_uglify(self):
153+
# Hack to workaround https://github.com/NativeScript/nativescript-dev-webpack/issues/602
154+
Tns.build_ios(attributes={"--path": self.app_name, "--release": "", "--for-device": "", "--bundle": ""})
155+
# ...remove the live above when the issues is fixed.
156+
153157
Tns.build_ios(attributes={"--path": self.app_name, "--release": "", "--for-device": "", "--bundle": "",
154158
"--env.uglify": "", "--env.aot": ""})
155159

tests/webpack/hello_world_ng_tests.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,10 @@ def test_100_android_build_release_with_bundle_and_uglify(self):
151151

152152
@unittest.skipIf(CURRENT_OS != OSType.OSX, "Run only on macOS.")
153153
def test_100_ios_build_release_with_bundle_and_uglify(self):
154+
# Hack to workaround https://github.com/NativeScript/nativescript-dev-webpack/issues/602
155+
Tns.build_ios(attributes={"--path": self.app_name, "--release": "", "--for-device": "", "--bundle": ""})
156+
# ...remove the live above when the issues is fixed.
157+
154158
Tns.build_ios(attributes={"--path": self.app_name, "--release": "", "--for-device": "", "--bundle": "",
155159
"--env.uglify": "", "--env.aot": ""})
156160

tests/webpack/hello_world_ts_tests.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,10 @@ def test_100_android_build_release_with_bundle_and_uglify(self):
150150

151151
@unittest.skipIf(CURRENT_OS != OSType.OSX, "Run only on macOS.")
152152
def test_100_ios_build_release_with_bundle_and_uglify(self):
153+
# Hack to workaround https://github.com/NativeScript/nativescript-dev-webpack/issues/602
154+
Tns.build_ios(attributes={"--path": self.app_name, "--release": "", "--for-device": "", "--bundle": ""})
155+
# ...remove the live above when the issues is fixed.
156+
153157
Tns.build_ios(attributes={"--path": self.app_name, "--release": "", "--for-device": "", "--bundle": "",
154158
"--env.uglify": "", "--env.aot": ""})
155159

0 commit comments

Comments
 (0)