Skip to content

Commit 4629dca

Browse files
author
Zdravko
authored
Merge pull request #1843 from NativeScript/zbranzov/fix-ui-tests
add: missing test images
2 parents 579a15b + 3da1b4e commit 4629dca

File tree

22 files changed

+19
-12
lines changed

22 files changed

+19
-12
lines changed
Loading
Loading
Loading

e2e/config/appium.capabilities.json

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,13 @@
120120
"noReset": true,
121121
"fullReset": false
122122
},
123+
"sim.iPhone7.ios12": {
124+
"platformName": "iOS",
125+
"platformVersion": "12.0",
126+
"deviceName": "iPhone 7",
127+
"noReset": true,
128+
"fullReset": false
129+
},
123130
"sim.iPhone8.iOS112": {
124131
"platformName": "iOS",
125132
"platformVersion": "11.2",
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Loading
Loading

e2e/routable-animations/e2e/setup.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import { startServer, stopServer } from "nativescript-dev-appium";
22

3-
before("start server", async () => {
3+
before("start server", async function () {
44
await startServer();
55
});
66

7-
after("stop server", async () => {
7+
after("stop server", async function () {
88
await stopServer();
99
});

e2e/routable-animations/e2e/tests.e2e.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@ describe("sample scenario", () => {
55
const defaultWaitTime = 5000;
66
let driver: AppiumDriver;
77

8-
before(async () => {
8+
before(async function () {
99
driver = await createDriver();
1010
});
1111

12-
after(async () => {
12+
after(async function () {
1313
await driver.quit();
1414
console.log("Quit driver!");
1515
});
@@ -20,7 +20,7 @@ describe("sample scenario", () => {
2020
}
2121
});
2222

23-
it("should go to support page", async () => {
23+
it("should go to support page", async function () {
2424
const btnGoToSupportPage = await driver.findElementByAutomationText("go to support page");
2525
const homeImage = await driver.compareScreen("home");
2626
assert.isTrue(homeImage);
@@ -29,7 +29,7 @@ describe("sample scenario", () => {
2929
console.log(await titleSupportPage.text());
3030
});
3131

32-
it("should go back to home page", async () => {
32+
it("should go back to home page", async function () {
3333
const btnGoBackToHomePage = await driver.findElementByAutomationText("go back to home page");
3434
const supportImage = await driver.compareScreen("support");
3535
assert.isTrue(supportImage);

e2e/router/e2e/router.e2e-spec.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -518,7 +518,7 @@ describe("Simple navigate and back should trigger only one CD on FirstComponent"
518518
describe("Simple navigate and back should trigger only one CD on FirstComponent even with 3 changes in service", () => {
519519
let driver: AppiumDriver;
520520

521-
before(async () => {
521+
before(async function () {
522522
driver = await createDriver();
523523
await driver.resetApp();
524524
});
@@ -529,30 +529,30 @@ describe("Simple navigate and back should trigger only one CD on FirstComponent
529529
}
530530
});
531531

532-
it("should find First", async () => {
532+
it("should find First", async function () {
533533
await assureFirstComponent(driver);
534534
});
535535

536-
it("should reset counter", async () => {
536+
it("should reset counter", async function () {
537537
await findAndClick(driver, "RESET");
538538
await driver.waitForElement("CHECK: 1");
539539
await driver.waitForElement("COUNTER: 0");
540540
});
541541

542-
it("should navigate to Second(1)/master", async () => {
542+
it("should navigate to Second(1)/master", async function () {
543543
await findAndClick(driver, "GO TO SECOND");
544544

545545
await assureSecondComponent(driver, 1);
546546
await assureNestedMasterComponent(driver);
547547
});
548548

549-
it("should increase counter", async () => {
549+
it("should increase counter", async function () {
550550
await findAndClick(driver, "TICK");
551551
await findAndClick(driver, "TICK");
552552
await findAndClick(driver, "TICK");
553553
});
554554

555-
it("should navigate back to First", async () => {
555+
it("should navigate back to First", async function () {
556556
await goBack(driver);
557557
await assureFirstComponent(driver);
558558
await driver.waitForElement("CHECK: 2");

0 commit comments

Comments
 (0)