chore(cleanup): Limit the use of lang-facade

Author: vakrilov

nativescript-angular/dom-adapter.ts

@@ -2,7 +2,6 @@
 import { Type } from "@angular/core";
 import { ɵDomAdapter } from "@angular/platform-browser";
 import { rendererLog } from "./trace";
-import { print } from "./lang-facade";
 
 export class NativeScriptDomAdapter implements ɵDomAdapter {
   static makeCurrent() {
@@ -27,15 +26,15 @@ export class NativeScriptDomAdapter implements ɵDomAdapter {
   }
 
   log(arg: any): void {
-    print(arg);
+    console.log(arg);
   }
 
   logError(arg: any): void {
-    print(arg);
+    console.log(arg);
   }
 
   logGroup(arg: any): void {
-    print(arg);
+    console.log(arg);
   }
 
   logGroupEnd(): void {

nativescript-angular/lang-facade.ts

@@ -1,67 +1,7 @@
-/* tslint:disable */
-//Copied unexported functions from @angular/core/src/facade/lang
-var globalScope = global;
-export var global = globalScope;
-
 export function isPresent(obj: any): boolean {
   return obj !== undefined && obj !== null;
 }
 
 export function isBlank(obj: any): boolean {
   return obj === undefined || obj === null;
 }
-
-export function isDate(obj: any): obj is Date {
-  return obj instanceof Date && !isNaN(obj.valueOf());
-}
-
-export function print(obj: Error | Object) {
-  console.log(obj);
-}
-
-export function isJsObject(o: any): boolean {
-  return o !== null && (typeof o === 'function' || typeof o === 'object');
-}
-
-export function isArray(obj: any): boolean {
-  return Array.isArray(obj);
-}
-
-// When Symbol.iterator doesn't exist, retrieves the key used in es6-shim
-declare var Symbol: any;
-let _symbolIterator: any = null;
-export function getSymbolIterator(): string|symbol {
-  if (isBlank(_symbolIterator)) {
-    if (isPresent((<any>globalScope).Symbol) && isPresent(Symbol.iterator)) {
-      _symbolIterator = Symbol.iterator;
-    } else {
-      // es6-shim specific logic
-      let keys = Object.getOwnPropertyNames(Map.prototype);
-      for (let i = 0; i < keys.length; ++i) {
-        let key = keys[i];
-        if (key !== 'entries' && key !== 'size' &&
-            (Map as any).prototype[key] === Map.prototype['entries']) {
-          _symbolIterator = key;
-        }
-      }
-    }
-  }
-  return _symbolIterator;
-}
-
-export function setValueOnPath(global: any, path: string, value: any) {
-  let parts = path.split('.');
-  let obj: any = global;
-  while (parts.length > 1) {
-    let name = parts.shift();
-    if (obj.hasOwnProperty(name) && isPresent(obj[name])) {
-      obj = obj[name];
-    } else {
-      obj = obj[name] = {};
-    }
-  }
-  if (obj === undefined || obj === null) {
-    obj = {};
-  }
-  obj[parts.shift()] = value;
-}

nativescript-angular/renderer.ts

@@ -11,7 +11,6 @@ import { topmost } from "tns-core-modules/ui/frame";
 import { profile } from "tns-core-modules/profiling";
 
 import { APP_ROOT_VIEW, DEVICE, getRootPage } from "./platform-providers";
-import { isBlank } from "./lang-facade";
 import { ViewUtil } from "./view-util";
 import { NgView, InvisibleNode } from "./element-registry";
 import { rendererLog as traceLog } from "./trace";
@@ -60,7 +59,7 @@ export class NativeScriptRendererFactory implements RendererFactory2 {
         }
 
         let renderer: NativeScriptRenderer = this.componentRenderers.get(type.id);
-        if (!isBlank(renderer)) {
+        if (renderer) {
             return renderer;
         }
 

nativescript-angular/router/page-router-outlet.ts

@@ -19,7 +19,6 @@ import { profile } from "tns-core-modules/profiling";
 
 import { BehaviorSubject } from "rxjs/BehaviorSubject";
 
-import { isPresent } from "../lang-facade";
 import { DEVICE, PAGE_FACTORY, PageFactory } from "../platform-providers";
 import { routerLog as log } from "../trace";
 import { DetachedLoader } from "../common/detached-loader";
@@ -40,9 +39,9 @@ export const pageRouterActivatedSymbol = Symbol("page-router-activated");
 export const loaderRefSymbol = Symbol("loader-ref");
 
 export function destroyComponentRef(componentRef: ComponentRef<any>) {
-    if (isPresent(componentRef)) {
+    if (componentRef) {
         const loaderRef = componentRef[loaderRefSymbol];
-        if (isPresent(loaderRef)) {
+        if (loaderRef) {
             loaderRef.destroy();
         }
         componentRef.destroy();