Skip to content

fix: modal beforeClosed and afterClosed consistency between platforms #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

edusperoni
Copy link
Collaborator

PR Checklist

What is the current behavior?

Currently when a modal closes the events fire quickly, often before the modal has fully closed. As a result, navigations done directly on the afterClosed callback won't work, needing a 0ms delay on iOS and >100ms on Android.

What is the new behavior?

We delay the afterClosed callback until we're sure the modal has fully closed

@cla-bot cla-bot bot added the cla: yes label Sep 13, 2022
@NathanWalker NathanWalker merged commit ad3e47c into main Sep 13, 2022
@NathanWalker NathanWalker deleted the fix/modal-timing branch September 13, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants