Skip to content

fix: patch showModal call in zone #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2022
Merged

fix: patch showModal call in zone #83

merged 1 commit into from
Aug 27, 2022

Conversation

edusperoni
Copy link
Collaborator

PR Checklist

What is the current behavior?

the view showModal is not patched, so the close callback may not always return on the angular zone

What is the new behavior?

We now patch the showModal method

@cla-bot cla-bot bot added the cla: yes label Aug 24, 2022
@NathanWalker NathanWalker merged commit 7b8389e into main Aug 27, 2022
@NathanWalker NathanWalker deleted the fix/modal-zone branch August 27, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants