Skip to content

feat: support adding TextNode elements (automatically sets text property by default) #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2022

Conversation

edusperoni
Copy link
Collaborator

@edusperoni edusperoni commented Aug 16, 2022

PR Checklist

What is the current behavior?

TextNodes are ignored

What is the new behavior?

Any invisible node can be supported (through the invisible node meta property). By default, when a TextNode is added to a view, it sets the view.text property and listen to any changes on the TextNode and reapplies the text property.

This allows for the very neat:

<Label>This works! {{ someProperty | async }}</Label>

@cla-bot cla-bot bot added the cla: yes label Aug 16, 2022
@NathanWalker NathanWalker merged commit 1be9c3a into main Aug 27, 2022
@NathanWalker NathanWalker deleted the feat/textnode-support branch August 27, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants