Add tests to cover scalar handling in launch() + Fix fp16 bug
#669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofang
commented
Jun 1, 2025
Comment on lines
+116
to
119
| elif supported_type is __half_raw: | ||
| (<supported_type*>ptr).x = <int16_t>(arg.view(numpy_int16)) | ||
| else: | ||
| (<supported_type*>ptr)[0] = <supported_type>(arg) |
There was a problem hiding this comment.
Here is the bug: When arg is a np.float16 scalar, the old code would treat it as int16_t (due to lack of standard C++ identifier for fp16 before C++23), and the scalar would be static_cast to int16_t, which triggered non-trivial conversion operators. The new code ensures that there is no conversion and the bytes are reinterpret_cast'd, and in order to hit this new path we need a unique type identifier, which is __half_raw.
|
/ok to test f4852bd |
This comment has been minimized.
This comment has been minimized.
|
/ok to test 63a68de |
kkraus14
approved these changes
Jun 2, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #260.
The test coverage revealed a bug in the fp16 scalar handling. The existing handling is obviously wrong and it's me to blame, but I honestly can't recall why I believed the code was correct 😞
Checklist