Skip to content
This repository was archived by the owner on Jul 13, 2020. It is now read-only.

Commit ae40618

Browse files
committed
Don't process module.module if module evaluation fails
(Reapply pull request #188)
1 parent c438cb3 commit ae40618

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

lib/loader.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -816,14 +816,14 @@ function logloads(loads) {
816816

817817
module.evaluated = true;
818818
err = doExecute(module);
819-
if (err)
819+
if (err) {
820820
module.failed = true;
821-
822-
// spec variation
823-
// we don't create a new module here because it was created and ammended
824-
// we just disable further extensions instead
825-
if (Object.preventExtensions)
821+
} else if (Object.preventExtensions) {
822+
// spec variation
823+
// we don't create a new module here because it was created and ammended
824+
// we just disable further extensions instead
826825
Object.preventExtensions(module.module);
826+
}
827827

828828
module.execute = undefined;
829829
return err;

0 commit comments

Comments
 (0)