Skip to content

Commit cb16280

Browse files
Fixed 'Select Window' always selecting the last window and not the
desired window.
1 parent f4bcb98 commit cb16280

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ CHANGES
33

44
unreleased
55
----------
6+
* Fixed 'Select Window' always selecting the last window and not the desired window.
67

78
1.4.0.5
89
-------

src/main/java/com/github/markusbernhardt/selenium2library/locators/WindowManager.java

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -97,18 +97,16 @@ protected static void selectMatching(WebDriver webDriver, Matcher matcher, Strin
9797
// Window of current WebDriver instance is already closed
9898
}
9999

100-
try {
101-
for (String handle : webDriver.getWindowHandles()) {
102-
webDriver.switchTo().window(handle);
103-
if (matcher.match(getCurrentWindowInfo(webDriver))) {
104-
return;
105-
}
106-
}
107-
} finally {
108-
if (startingHandle != null) {
109-
webDriver.switchTo().window(startingHandle);
100+
for (String handle : webDriver.getWindowHandles()) {
101+
webDriver.switchTo().window(handle);
102+
if (matcher.match(getCurrentWindowInfo(webDriver))) {
103+
return;
110104
}
111105
}
106+
107+
if (startingHandle != null) {
108+
webDriver.switchTo().window(startingHandle);
109+
}
112110
throw new Selenium2LibraryNonFatalException(error);
113111
}
114112
}

0 commit comments

Comments
 (0)