Move all mentions of transport from CoreProtocol to BaseProtocol

Transport is an asyncio concern and should logically be in the
BaseProtocol.

Author: elprans

asyncpg/protocol/coreproto.pyx

@@ -17,7 +17,6 @@ cdef class CoreProtocol:
         self.password = con_params.password
         self.auth_msg = None
         self.con_params = con_params
-        self.transport = None
         self.con_status = CONNECTION_BAD
         self.state = PROTOCOL_IDLE
         self.xact_status = PQTRANS_IDLE
@@ -32,9 +31,6 @@ cdef class CoreProtocol:
 
         self._reset_result()
 
-    cdef _write(self, buf):
-        self.transport.write(memoryview(buf))
-
     cdef _read_server_messages(self):
         cdef:
             char mtype
@@ -147,7 +143,6 @@ cdef class CoreProtocol:
             if self.result_type != RESULT_OK:
                 self.con_status = CONNECTION_BAD
                 self._push_result()
-                self.transport.close()
 
             elif self.auth_msg is not None:
                 # Server wants us to send auth data, so do that.
@@ -910,6 +905,9 @@ cdef class CoreProtocol:
         buf.end_message()
         self._write(buf)
 
+    cdef _write(self, buf):
+        raise NotImplementedError
+
     cdef _decode_row(self, const char* buf, ssize_t buf_len):
         pass
 

asyncpg/protocol/protocol.pyx

@@ -98,6 +98,7 @@ cdef class BaseProtocol(CoreProtocol):
         CoreProtocol.__init__(self, con_params)
 
         self.loop = loop
+        self.transport = None
         self.waiter = connected_fut
         self.cancel_waiter = None
         self.cancel_sent_waiter = None
@@ -883,6 +884,9 @@ cdef class BaseProtocol(CoreProtocol):
             self.closing = True
             self._handle_waiter_on_connection_lost(exc)
 
+    cdef _write(self, buf):
+        self.transport.write(memoryview(buf))
+
     # asyncio callbacks:
 
     def data_received(self, data):