Skip to content

Commit ca41d89

Browse files
authored
Merge pull request #165 from mattip/macos-13
use macos-13 instead of macos-11
2 parents 4b4b650 + a03b11b commit ca41d89

File tree

3 files changed

+26
-20
lines changed

3 files changed

+26
-20
lines changed

.github/workflows/posix.yml

Lines changed: 21 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,16 @@ jobs:
1818
strategy:
1919
fail-fast: false
2020
matrix:
21-
os: [ubuntu-latest, macos-11]
21+
os: [ubuntu-latest, macos-13]
2222
PLAT: [i686, x86_64]
2323
INTERFACE64: ['0', '1']
2424
MB_ML_VER: ['2014']
2525
MB_ML_LIBC: ['manylinux']
2626
include:
27-
- os: macos-11
27+
- os: macos-13
2828
PLAT: arm64
2929
INTERFACE64: '1'
30-
- os: macos-11
30+
- os: macos-13
3131
PLAT: arm64
3232
INTERFACE64: '0'
3333
- os: ubuntu-latest
@@ -42,7 +42,7 @@ jobs:
4242
MB_ML_VER: _1_1
4343
exclude:
4444
- PLAT: i686
45-
os: macos-11
45+
os: macos-13
4646
- PLAT: i686
4747
INTERFACE64: '1'
4848
env:
@@ -69,13 +69,13 @@ jobs:
6969
python-version: 3.9
7070
- name: Set extra env
7171
run: |
72-
# if [ "macos-11" == "${{ matrix.os }}" ]; then
73-
# Use xcrun --sdk macosx --show-sdk-path instead of hardcoding the path
74-
# echo "LDFLAGS=-L/Library/Developer/CommandLineTools/SDKs/MacOSX12.1.sdk/usr/lib" >> $GITHUB_ENV;
75-
# echo "LIBRARY_PATH=-L/Library/Developer/CommandLineTools/SDKs/MacOSX12.1.sdk/usr/lib" >> $GITHUB_ENV;
76-
# else
77-
# fi
7872
echo "DOCKER_TEST_IMAGE=$(echo multibuild/xenial_${{ matrix.PLAT}})" >> $GITHUB_ENV;
73+
74+
- uses: maxim-lobanov/setup-xcode@v1.6.0
75+
if: ${{ matrix.os == 'macos-13' }}
76+
with:
77+
xcode-version: '14.3'
78+
7979
- name: Print some Environment variable
8080
run: |
8181
echo "PLAT: ${PLAT}"
@@ -87,11 +87,6 @@ jobs:
8787
- name: Build OpenBLAS
8888
run: |
8989
set -xeo pipefail
90-
if [[ "$PLAT" == "arm64" ]]; then
91-
sudo xcode-select -switch /Applications/Xcode_12.5.1.app
92-
export SDKROOT=/Applications/Xcode_12.5.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk
93-
clang --version
94-
fi
9590
source tools/build_steps.sh
9691
echo "------ BEFORE BUILD ---------"
9792
before_build
@@ -107,14 +102,20 @@ jobs:
107102
build_lib "$PLAT" "$INTERFACE64" "0"
108103
fi
109104
105+
# - name: Setup tmate session
106+
# if: ${{ failure() }}
107+
# uses: mxschmitt/action-tmate@v3
108+
# with:
109+
# limit-access-to-actor: true
110+
110111
- name: Build and test wheel
111112
run: |
112113
if [[ "$NIGHTLY" = "true" ]]; then
113114
# Set the pyproject.toml version: convert v0.3.24-30-g138ed79f to 0.3.34.30
114115
version=$(cd OpenBLAS && git describe --tags --abbrev=8 | sed -e "s/^v\(.*\)-g.*/\1/" | sed -e "s/-/./g")
115116
sed -e "s/^version = .*/version = \"${version}\"/" -i.bak pyproject.toml
116117
fi
117-
if [ "macos-11" == "${{ matrix.os }}" ]; then
118+
if [ "macos-13" == "${{ matrix.os }}" ]; then
118119
source tools/build_wheel.sh
119120
else
120121
libc=${MB_ML_LIBC:-manylinux}
@@ -136,9 +137,12 @@ jobs:
136137
name: openblas-${{ matrix.os }}-${{ matrix.PLAT }}-${{ matrix.INTERFACE64 }}-${{ matrix.MB_ML_LIBC }}
137138
path: libs/openblas*.tar.gz
138139

139-
- uses: conda-incubator/setup-miniconda@v3.0.1
140+
- uses: conda-incubator/setup-miniconda@v3.0.4
140141
with:
142+
channels: conda-forge
143+
channel-priority: true
141144
activate-environment: upload
145+
miniforge-version: latest
142146

143147
- name: Upload
144148
# see https://github.com/marketplace/actions/setup-miniconda for why

tools/build_steps.sh

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ function build_lib {
5555
# OSX or manylinux build
5656
#
5757
# Input arg
58-
# plat - one of i686, x86_64
58+
# plat - one of i686, x86_64, arm64
5959
# interface64 - 1 if build with INTERFACE64 and SYMBOLSUFFIX
6060
# nightly - 1 if building for nightlies
6161
#
@@ -103,7 +103,7 @@ function patch_source {
103103
function do_build_lib {
104104
# Build openblas lib
105105
# Input arg
106-
# plat - one of i686, x86_64
106+
# plat - one of i686, x86_64, arm64
107107
# suffix (optional) - suffix for output archive name
108108
# Suffix added with hyphen prefix
109109
# interface64 (optional) - whether to build ILP64 openblas
@@ -125,6 +125,8 @@ function do_build_lib {
125125
Darwin-x86_64)
126126
local bitness=64
127127
local target_flags="TARGET=CORE2"
128+
# Pick up the gfortran runtime libraries
129+
export DYLD_LIBRARY_PATH=/usr/local/lib:$DYLD_LIBRARY_PATH
128130
;;
129131
*-i686)
130132
local bitness=32

tools/build_wheel.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ if [ "${INTERFACE64}" != "1" ]; then
7070
fi
7171

7272
rm -rf dist/*
73-
$PYTHON -m pip wheel -w dist -vv .
73+
$PYTHON -m pip wheel -w dist -v .
7474

7575
if [ $(uname) == "Darwin" ]; then
7676
$PYTHON -m pip install delocate

0 commit comments

Comments
 (0)