create an ABI3 wheel when possible

Author: mayeut

.github/workflows/posix.yml

@@ -122,9 +122,21 @@ jobs:
       run: |
         mkdir -p local/openblas
         tar -C local/openblas --strip-components=2 -xf libs/openblas*.tar.gz
-        # do not package the static libs, they are ~55MB
-        rm local/openblas/*.a
-        python -m pip wheel -w dist -vv .
+        cp local/openblas/lib/libopenblas64_.so local/openblas/libopenblas_python.so
+        # do not package the static libs and symlinks, they are ~55MB
+        rm -rf local/openblas/lib/*
+        mv local/openblas/libopenblas_python.so local/openblas/lib/
+
+        cat <<EOF > run_in_docker.sh
+        cd /openblas
+        patchelf --set-soname libopenblas_python.so local/openblas/lib/libopenblas_python.so
+        python3.7 -m pip wheel -w /tmp/wheelhouse -vv .
+        auditwheel repair -w dist/ /tmp/wheelhouse/openblas-*.whl
+        python3.10 -m pip install dist/openblas-*.whl
+        python3.10 -m openblas
+        EOF
+
+        docker run --rm -v $(pwd):/openblas quay.io/pypa/manylinux2014_x86_64 /bin/bash -xe /openblas/run_in_docker.sh
 
     - uses: actions/upload-artifact@v3
       with:

local/openblas/__init__.py

@@ -17,11 +17,3 @@
     __version__ = "0.0.0"
 
 openblas_config = _init_openblas.get_config()
-
-path_to_so = os.path.join(os.path.dirname(__file__), 'lib', 'libopenblas64_.so')
-
-
-def open_so():
-    _init_openblas.open_so(path_to_so)
-
-

pyproject.toml

@@ -9,6 +9,7 @@ build-backend = "setuptools.build_meta"
 [project]
 name = "openblas"
 version = "0.3.20"
+requires-python = ">=3.7"
 description = "Provides OpenBLAS for python packaging"
 readme = "README.md"
 classifiers = [
@@ -36,14 +37,3 @@ install_requires = "importlib-metadata ~= 1.0 ; python_version < '3.8'"
 
 [tool.setuptools.package-data]
 openblas = ["lib/*", "include/*", "lib/pkgconfig/*", "lib/cmake/openblas/*"]
-
-
-#[tool.setuptools.data_files]
-# Deprecated in setuptools, but may be revived as a new standard, see
-# https://discuss.python.org/t/pep-proposal-external-data-for-python-packages
-#"/local" = [
-#  "local/include/*.h",
-#  "local/lib/*",
-#  "local/lib/pkgconfig/*",
-#  "local/lib/cmake/OpenBLAS/*",
-#]

setup.py

@@ -1,23 +1,41 @@
 import os
+import sys
 from setuptools import setup, Extension
+from wheel.bdist_wheel import bdist_wheel
+
 
 mydir = os.path.abspath(os.path.dirname(__file__))
 
+
+class bdist_wheel_abi3(bdist_wheel):
+    def get_tag(self):
+        python, abi, plat = bdist_wheel.get_tag(self)
+        return python, "abi3", plat
+
+
 # TODO: determine if we are building 64- or 32- bit interfaces
 use_64=True
 if use_64:
-    libraries = ["openblas64_",]
     macros = [("SUFFIX", "64_")]
 else:
-    libraries = ["openblas",]
     macros = []
 
+if sys.implementation.name == "cpython":
+    cmdclass = {"bdist_wheel": bdist_wheel_abi3}
+    py_limited_api = {"py_limited_api": True}
+    macros.append(('Py_LIMITED_API', '0x03070000'))
+else:
+    cmdclass = {}
+    py_limited_api = {}
+
 setup(
+    cmdclass=cmdclass,
     ext_modules=[Extension(
-            "openblas._init_openblas", ["src/_init_openblas.c"],
-            libraries=libraries,
-            library_dirs=[os.path.join(mydir, 'local', 'openblas', 'lib'),],
-            extra_link_args=["-Wl,-rpath,$ORIGIN/lib"],
-            define_macros=macros,
+        "openblas._init_openblas", ["src/_init_openblas.c"],
+        libraries=["openblas_python"],
+        library_dirs=[os.path.join(mydir, 'local', 'openblas', 'lib'),],
+        extra_link_args=["-Wl,-rpath,$ORIGIN/lib"],
+        define_macros=macros,
+        **py_limited_api
     )],
 )

src/_init_openblas.c

@@ -1,6 +1,4 @@
-#include "Python.h"
-#include <dlfcn.h>
-#include <stdio.h>
+#include <Python.h>
 
 #ifdef SUFFIX
   #define openblas_get_config openblas_get_config64_
@@ -14,25 +12,9 @@ get_config(PyObject *self, PyObject *args) {
     return PyUnicode_FromString(config);
 }
 
-PyObject*
-open_so(PyObject *self, PyObject *args) {
-    const char *utf8 = PyUnicode_AsUTF8(args);
-    if (utf8 == NULL) {
-        return NULL;
-    }
-    void *handle = dlopen(utf8, RTLD_GLOBAL | RTLD_NOW);
-    if (handle == NULL) {
-        PyErr_SetString(PyExc_ValueError, "Could not open SO");
-        return NULL;
-    }
-    Py_RETURN_TRUE; 
-}
-
 static PyMethodDef InitMethods[] = {
     {"get_config",  get_config, METH_NOARGS,
      "Return openblas_get_config(), see https://github.com/xianyi/OpenBLAS/wiki/OpenBLAS-Extensions"},
-    {"open_so", open_so, METH_O,
-     "Use dlopen to load the shared object, which must exist"},
     {NULL, NULL, 0, NULL}        /* Sentinel */
 };