Merge pull request #2747 from NeOzay/master

fix: add a missing check for 'inject-field' diagnostics

Author: sumneko

changelog.md

@@ -7,6 +7,7 @@
 * `NEW` Add support for lambda style functions, `|paramList| expr` is syntactic sugar for `function(paramList) return expr end` 
 * `FIX` Respect `completion.showParams` config for local function completion 
 * `CHG` Improve performance of multithreaded `--check` and `undefined-field` diagnostic
+* `FIX` Bad triggering of the `inject-field` diagnostic, when the fields are declared at the creation of the object [#2746](https://github.com/LuaLS/lua-language-server/issues/2746)
 * `CHG` Change spacing of parameter inlay hints to match other LSPs, like `rust-analyzer`
 
 ## 3.9.3

script/core/diagnostics/inject-field.lua

@@ -68,6 +68,9 @@ return function (uri, callback)
             if def.type == 'doc.field' then
                 return
             end
+            if def.type == 'tablefield' and not isExact then
+                return
+            end
         end
 
         local howToFix = ''

test/diagnostics/inject-field.lua

@@ -82,3 +82,16 @@ function m:init() -- OK
     end
 end
 ]]
+
+TEST [[
+---@class Class
+local m = {
+    xx = 1, -- OK
+}
+
+---@type Class
+local m
+
+m.xx = 1 -- OK
+m.<!yy!> = 1 -- Warning
+]]