Skip to content

Commit d8eb483

Browse files
committed
Reverse EventCallback state$ and inputs$ order
1 parent ab46ff3 commit d8eb483

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,8 @@ type EventCallback<EventValue, State, Inputs> = Inputs extends void
202202
? (eventSource$: Observable<EventValue>, state$: Observable<State>) => Observable<State>
203203
: (
204204
eventSource$: Observable<EventValue>,
205-
inputs$: Observable<RestrictArray<Inputs>>,
206205
state$: Observable<State>,
206+
inputs$: Observable<RestrictArray<Inputs>>,
207207
) => Observable<State>
208208
209209
declare function useEventCallback<EventValue, State = void>(
@@ -335,7 +335,7 @@ import "./styles.css";
335335
function App() {
336336
const [count, setCount] = useState(0);
337337
const [clickCallback, [description, x, y, prevDesc]] = useEventCallback(
338-
(event$, inputs$, state$) =>
338+
(event$, state$, inputs$) =>
339339
event$.pipe(
340340
map(event => [event.target.innerHTML, event.clientX, event.clientY]),
341341
combineLatest(inputs$),

src/__test__/use-event-callback.spec.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,8 @@ describe('useEventCallback specs', () => {
134134
const timeToDelay = 200
135135
const factory = (
136136
event$: Observable<React.MouseEvent<HTMLButtonElement>>,
137-
inputs$: Observable<number[]>,
138137
_state$: Observable<number>,
138+
inputs$: Observable<number[]>,
139139
): Observable<number> =>
140140
event$.pipe(
141141
combineLatest(inputs$),

src/use-event-callback.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ export type EventCallback<EventValue, State, Inputs> = Not<
1919
Inputs extends void ? true : false,
2020
(
2121
eventSource$: Observable<EventValue>,
22-
inputs$: Observable<RestrictArray<Inputs>>,
2322
state$: Observable<State>,
23+
inputs$: Observable<RestrictArray<Inputs>>,
2424
) => Observable<State>,
2525
(eventSource$: Observable<EventValue>, state$: Observable<State>) => Observable<State>
2626
>
@@ -67,7 +67,7 @@ export function useEventCallback<EventValue, State = void, Inputs = void>(
6767
if (!inputs) {
6868
value$ = (callback as EventCallback<EventValue, State, void>)(event$, state$ as Observable<State>)
6969
} else {
70-
value$ = (callback as any)(event$, inputs$ as Observable<Inputs>, state$ as Observable<State>)
70+
value$ = (callback as any)(event$, state$ as Observable<State>, inputs$ as Observable<Inputs>)
7171
}
7272
const subscription = value$.subscribe((value) => {
7373
state$.next(value)

0 commit comments

Comments
 (0)