Skip to content

Commit 3c36d7e

Browse files
committed
ci(github): Added build step & pull_request trigger
Build step ensures that no errors in code will be missed. Without building there could, for example, be a missing property on a type, which would fail during build yet pass during CI, because the js runs properly. pull_request trigger should ensure all tests are run and pass during a PR
1 parent eab425b commit 3c36d7e

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

.github/workflows/main.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Node.js CI
22

3-
on: [push]
3+
on: [push, pull_request]
44

55
jobs:
66
build:
@@ -34,6 +34,9 @@ jobs:
3434
- name: Install Packages
3535
run: yarn install --frozen-lockfile
3636

37+
- name: Build
38+
run: yarn build
39+
3740
- name: Test
3841
run: yarn test
3942
env:

0 commit comments

Comments
 (0)